Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist checkpoints in evaluation history db #4059

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Aug 2, 2024

Summary

This starts adding ingest checkpoint data into the history log.

The main benefit here is that we'd have commit/branch information for git-related ingests.

artifacts require a little more work and will be handled in a separate PR.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner August 2, 2024 06:37
@JAORMX JAORMX force-pushed the checkpoint-history branch 2 times, most recently from afbeeb0 to c331366 Compare August 2, 2024 09:25
@JAORMX JAORMX requested review from eleftherias and dmjb August 2, 2024 09:30
@JAORMX JAORMX force-pushed the checkpoint-history branch from c331366 to 2972c15 Compare August 2, 2024 11:14
@coveralls
Copy link

Coverage Status

coverage: 54.408% (+0.04%) from 54.365%
when pulling 2972c15 on checkpoint-history
into ba65aff on main.

@JAORMX JAORMX merged commit 069f873 into main Aug 2, 2024
21 checks passed
@JAORMX JAORMX deleted the checkpoint-history branch August 2, 2024 11:27
rdimitrov added a commit that referenced this pull request Aug 2, 2024
rdimitrov added a commit that referenced this pull request Aug 2, 2024
Revert "Persist checkpoints in evaluation history db (#4059)"

This reverts commit 069f873.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants