mailer: allow configuration option to change the Mailer's superclass #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulRbr
force-pushed
the
add-config-parent-mailer
branch
from
6c2842e to
fb8b996
Compare
|
I'm on board with this 👍 |
This PR adds a `parent_mailer` configuration option to the Engine which can receive a Mailer class from which the passwordless mailer will inherit from. By default the Mailer inherits from `ACtionMailer::Base` but allowing the superclass to be configurable gives users the possibility to inherit from their own `ApplicationMailer` class for instance. This is handy to be able to share users' mailer configuration between all mailers (including the own provided by Passwordless engine). About mikker#78
paulRbr
force-pushed
the
add-config-parent-mailer
branch
from
fb8b996 to
32717ff
Compare
Sure! It's done ✓. Let me know if you need anything else. |
|
@mikker any news to get this PR merged in? Do you need something more from me? |
|
Looks good, sorry. Blame hectic quarantine days. |
|
💙💚💛💜❤️ |
|
Haha, no worries.
Thanks for the review!
🤗 💛💚💙🖤
Em 30 de abril de 2020 22:34:14 GMT+02:00, Mikkel Malmberg <[email protected]> escreveu:
… 💙💚💛💜❤️>
>
-- >
You are receiving this because you authored the thread.>
Reply to this email directly or view it on GitHub:>
#82 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
parent_mailerconfiguration option to the Enginewhich can receive a Mailer class from which the passwordless mailer
will inherit from.
By default the Mailer inherits from
ACtionMailer::Basebut allowingthe superclass to be configurable gives users the possibility to
inherit from their own
ApplicationMailerclass for instance.This is handy to be able to share users' mailer configuration between
all mailers (including the own provided by Passwordless engine).
About #78. These changes are directly inspired by Devise.