Allow to config parent mailer #78
Comments
|
This sounds like an okay approach. PR welcome. We'll need to support both ways until next major (1.0) so no need to pull out the current approach in you PR 😊 |
paulRbr
added a commit
to paulRbr/passwordless
that referenced
this issue
Apr 20, 2020
This PR adds a `parent_mailer` configuration option to the Engine which can receive a Mailer class from which the passwordless mailer will inherit from. By default the Mailer inherits from `ACtionMailer::Base` but allowing the superclass to be configurable gives users the possibility to inherit from their own `ApplicationMailer` class for instance. This is handy to be able to share users' mailer configuration between all mailers (including the own provided by Passwordless engine). About mikker#78
paulRbr
added a commit
to paulRbr/passwordless
that referenced
this issue
Apr 20, 2020
This PR adds a `parent_mailer` configuration option to the Engine which can receive a Mailer class from which the passwordless mailer will inherit from. By default the Mailer inherits from `ACtionMailer::Base` but allowing the superclass to be configurable gives users the possibility to inherit from their own `ApplicationMailer` class for instance. This is handy to be able to share users' mailer configuration between all mailers (including the own provided by Passwordless engine). About mikker#78
paulRbr
added a commit
to paulRbr/passwordless
that referenced
this issue
Apr 20, 2020
This PR adds a `parent_mailer` configuration option to the Engine which can receive a Mailer class from which the passwordless mailer will inherit from. By default the Mailer inherits from `ACtionMailer::Base` but allowing the superclass to be configurable gives users the possibility to inherit from their own `ApplicationMailer` class for instance. This is handy to be able to share users' mailer configuration between all mailers (including the own provided by Passwordless engine). About mikker#78
mikker
pushed a commit
that referenced
this issue
Apr 30, 2020
This PR adds a `parent_mailer` configuration option to the Engine which can receive a Mailer class from which the passwordless mailer will inherit from. By default the Mailer inherits from `ACtionMailer::Base` but allowing the superclass to be configurable gives users the possibility to inherit from their own `ApplicationMailer` class for instance. This is handy to be able to share users' mailer configuration between all mailers (including the own provided by Passwordless engine). About #78
|
Closed in #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
if we do like this
And our mailer inherit from that parent_mailer
So we can allow user to custom options and layout by their base on rails config
We can also remove this remove this
Passwordless.default_from_address = "[email protected]"It got this concept from devise. If you are ok I can help
The text was updated successfully, but these errors were encountered: