Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode-insiders #327

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions manifests/Microsoft/VisualStudioCodeInsiders/1.46.0.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Id: Microsoft.VisualStudioCodeInsiders
Version: 1.46.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically not correct as the version is x.y.z-insider, but having the version number would require us to change it once a month. I was wondering in https://github.com/microsoft/winget-pkgs/issues/278 if we can use something like "Latest" or "Insider" here instead.

Name: Visual Studio Code Insiders
Publisher: Microsoft Corporation
License: Copyright (c) Microsoft Corporation
AppMoniker: vscode-insiders
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to get #277 sorted out before we do insiders, ideally we would use code and code-insiders to match the CLI and have vscode as an alias/search term.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added my opinion on it!

Description: Visual Studio Code is a code editor redefined and optimized for building and debugging modern web and cloud applications. Visual Studio Code is free and available on your favorite platform - Linux, macOS, and Windows.
Homepage: https://code.visualstudio.com/insiders/
Installers:
- Arch: x64
Url: https://go.microsoft.com/fwlink/?Linkid=852155
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably be better: https://update.code.visualstudio.com/latest/win32-x64-user/insider, the hash won't work though as it changes every day. While certainly possible, it would be preferable not to need a PR (or automated commit) everyday to do this. I also saw that sources (winget source) are supported, are all Microsoft packages meant to be maintained in this repo? It would be easier to automate if we owned the repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scoop also had to deal with this in ScoopInstaller/Scoop#181, and they added simplistic nightly support. Might be worth to see that they did.

Sha256: 434A9433B72692C0C579A33B1C20EB72BD05ED3BB533A34A76C9702482FA9A3E
InstallerType: inno