Add vscode-insiders #327
Add vscode-insiders #327
Conversation
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wingetbot
added
the
Azure-Pipeline-Passed
ghost
assigned 
|
This submission has moved to manual review. |
There was a problem hiding this comment.
I started a conversation about how to do this in https://github.com/microsoft/winget-pkgs/issues/278. The comments are for @KevinLaMS
| @@ -0,0 +1,13 @@ | |||
| Id: Microsoft.VisualStudioCodeInsiders | |||
| Version: 1.46.0 | |||
There was a problem hiding this comment.
This is technically not correct as the version is x.y.z-insider, but having the version number would require us to change it once a month. I was wondering in https://github.com/microsoft/winget-pkgs/issues/278 if we can use something like "Latest" or "Insider" here instead.
| Name: Visual Studio Code Insiders | ||
| Publisher: Microsoft Corporation | ||
| License: Copyright (c) Microsoft Corporation | ||
| AppMoniker: vscode-insiders |
There was a problem hiding this comment.
I want to get #277 sorted out before we do insiders, ideally we would use code and code-insiders to match the CLI and have vscode as an alias/search term.
There was a problem hiding this comment.
Thanks, I added my opinion on it!
| Homepage: https://code.visualstudio.com/insiders/ | ||
| Installers: | ||
| - Arch: x64 | ||
| Url: https://go.microsoft.com/fwlink/?Linkid=852155 |
There was a problem hiding this comment.
This would probably be better: https://update.code.visualstudio.com/latest/win32-x64-user/insider, the hash won't work though as it changes every day. While certainly possible, it would be preferable not to need a PR (or automated commit) everyday to do this. I also saw that sources (winget source) are supported, are all Microsoft packages meant to be maintained in this repo? It would be easier to automate if we owned the repo.
There was a problem hiding this comment.
Scoop also had to deal with this in ScoopInstaller/Scoop#181, and they added simplistic nightly support. Might be worth to see that they did.
KevinLaMS
added
Needs: author feedback
and removed
Azure-Pipeline-Passed
|
Sure! |
Closes #320
Microsoft Reviewers: Open in CodeFlow