Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings - Add string validator for color-hex format #106038

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Settings - Add string validator for color-hex format #106038

merged 1 commit into from
Sep 3, 2020

Conversation

lszomoru
Copy link
Member

@lszomoru lszomoru commented Sep 3, 2020

This PR fixes #105854

@lszomoru lszomoru added the settings-editor VS Code settings editor issues label Sep 3, 2020
@lszomoru lszomoru added this to the August 2020 milestone Sep 3, 2020
@lszomoru lszomoru requested a review from roblourens September 3, 2020 12:17
@lszomoru lszomoru self-assigned this Sep 3, 2020
roblourens
roblourens approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens merged commit 616afa9 into master Sep 3, 2020
@roblourens roblourens deleted the lszomoru/color-setting branch September 3, 2020 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@lszomoru lszomoru

Labels
settings-editor VS Code settings editor issues
Projects
None yet
Milestone
August 2020
Development

Successfully merging this pull request may close these issues.

Screencast: return mouse indicator entry back to "red" after invalid entry, or add warning
2 participants
@lszomoru @roblourens