Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screencast: return mouse indicator entry back to "red" after invalid entry, or add warning #105854

Closed
bamurtaugh opened this issue Sep 1, 2020 · 5 comments · Fixed by #106038
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders screencast-mode verified Verification succeeded
Milestone

Comments

@bamurtaugh
Copy link
Member

Testing #105721

The Mouse Indicator Color setting functions properly when I enter an invalid color: it defaults back to a red indicator. But I was thinking perhaps adding a warning message to users that they have entered an invalid color (like the warning for invalid Mouse Indicator Size), and/or auto-filling the entry back to red would emphasize to them why their indicator has turned red again.

@bamurtaugh bamurtaugh changed the title Screencast: return mouse indicator color back to "red" after invalid entry, or add warning Screencast: return mouse indicator entry back to "red" after invalid entry, or add warning Sep 1, 2020
@lszomoru lszomoru added this to the August 2020 milestone Sep 2, 2020
@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Sep 2, 2020
@lszomoru
Copy link
Member

lszomoru commented Sep 2, 2020

The setting is of type string, with format: "color-hex" which provides a good error message while editing the setting in the JSON file. As far as I can tell there is no way to currently get the same experience in the settings UI. I do agree that it would be nice to have a better experience for editing color settings in the settings UI.

@roblourens, have we ever considered adding a color type/validation for a setting?

@roblourens
Copy link
Member

We have to implement these individually and that format isn't implemented yet

@roblourens roblourens added feature-request Request for new features or functionality settings-editor VS Code settings editor issues screencast-mode and removed screencast-mode feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Sep 2, 2020
@roblourens
Copy link
Member

It would be a feature request for the settings editor, probably easy, feel free to assign it to me

@lszomoru
Copy link
Member

lszomoru commented Sep 2, 2020

@roblourens, would you be opened for me to submit a pull request?
I would be happy to take a stab at this in my free time to learn more about our codebase.

@roblourens
Copy link
Member

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Sep 3, 2020
@chrmarti chrmarti added the verified Verification succeeded label Sep 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders screencast-mode verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@roblourens @lszomoru @chrmarti @bamurtaugh and others