1.54.1 update today broke the VSCode JavaScript debugger on my machine. (Windows10x64)

[dirck]

Issue Type: Bug

After allowing VSCode to run the 1.54.1 update today, when attempting to debug javascript, vscode presents:

"Couldn't find a debug adapter descriptor for debug type 'pwa-node' (extension may have failed to activate)"

Debug efforts:

• Uninstalled vscode
• Reinstalled vscode (Windows "System Installer" x64)

no change

• Uninstalled vscode
• Completely hosed out %APPDATA%/code
• Reinstalled vscode (Windows "System Installer" x64)

no change

(note the previously installed extensions still appear in vscode after hosing out %APPDATA%/code, not sure where they live.)

Tested with and without --disable-extensions option

---

Highlights from code --disable-extensions --verbose --log debug

Multiple occurrences of:

[32776:0310/160830.059:INFO:CONSOLE(25)] "%cTRACE color: #888 Error: ENOENT: no such file or directory, open 'c:\Program Files\Microsoft VS Code\resources\app\extensions\node_modules\package.json'", source: file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js (25)

One time:

[32776:0310/160830.788:INFO:CONSOLE(626)] "%cTRACE color: #888 CommandService#executeCommand extension.js-debug.clearAutoAttachVariables", source: file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js (626)

Previous log before second reinstall includes both of the above plus this message, not present in the latest log:

[34784:0310/155307.979:INFO:CONSOLE(1857)] "Activating extension 'ms-vscode.js-debug' failed: a DebugAdapterDescriptorFactory can only be registered from the extension that defines the 'pwa-extensionHost' debugger..", source: file:///C:/PROGRA~1/MIFA7F~1/resources/app/out/vs/workbench/workbench.desktop.main.js (1857)

VS Code version: Code 1.54.1 (f30a9b7, 2021-03-04T22:38:31.419Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item	Value
CPUs	Intel(R) Xeon(R) CPU E3-1270 V2 @ 3.50GHz (8 x 3492)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.95GB (18.63GB free)
Process Argv	--disable-extensions --verbose --log debug --crash-reporter-id 39bea185-078d-4173-a244-da107d90ee57
Screen Reader	no
VM	0%

Extensions disabled

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vstry244cf:30256637
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
dockersubset:30270708
pythontb:30265425
vspre833cf:30267465

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• VS Code keep crashing on Ubuntu 20.04 (#118398)
• Crashes instantly on startup. Ubuntu 20.10 (#118169)

[dirck]

After I made the report the debugger started working. WTF?

[dirck]

It came back and I still haven't pinned it to anything. Might be related to an extension doing something globally, even though it still happens with extensions disabled.

Still comes and goes. When it fails I get the

command 'extension.js-debug.clearAutoAttachVariables' not found: Error: command 'extension.js-debug.clearAutoAttachVariables' not found

error

[dirck]

I've got something I can reproduce; if I run it like this:

"C:\Program Files\Microsoft VS Code\bin\code.CMD" .

it works, and if I run it like this:

c:\progra~1\MIFA7F~1\bin\code.cmd .

it fails.

Weird.

[dirck]

Logs if anybody is interested

"C:\Program Files\Microsoft VS Code\bin\code.CMD" --disable-extensions --verbose . > ok

ok.log

c:\progra~1\MIFA7F~1\bin\code.cmd --disable-extensions --verbose . > notok

notok.log

[connor4312]

cc Andre:

Activating extension 'ms-vscode.js-debug' failed: a DebugAdapterDescriptorFactory can only be registered from the extension that defines the 'pwa-extensionHost' debugger..", source: file:///C:/PROGRA1/MIFA7F1/resources/app/out/vs/workbench/workbench.desktop.main.js

[weinand]

@connor4312 I have never seen the check from above failing randomly.
Here is the code:

vscode/src/vs/workbench/api/common/extHostDebugService.ts

Lines 745 to 760 in d574f8e

	private definesDebugType(ed: IExtensionDescription, type: string) {
	if (ed.contributes) {
	const debuggers = <IDebuggerContribution[]>ed.contributes['debuggers'];
	if (debuggers && debuggers.length > 0) {
	for (const dbg of debuggers) {
	// only debugger contributions with a "label" are considered a "defining" debugger contribution
	if (dbg.label && dbg.type) {
	if (dbg.type === type) {
	return true;
	}
	}
	}
	}
	}
	return false;
	}

Did something change in that area?

[connor4312]

I have not changed anything there. But also looking at the "notok.log" the user posted in #118679 (comment), it looks like there are a few other weird errors with extensions, so maybe this is deeper down in the stack.

[Onurtag]

Having the same problem.
#118562 might be similar to this issue.

[weinand]

/duplicate #118562

[dirck]

Verified fixed in 1.54.3

[weinand]

@dirck thanks for verifying!