-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS Code is unable to activate a debugger extension because of path casing discrepancies #118562
Comments
(Experimental duplicate detection)
|
I'm affected. |
@vscodebot It doesn't appear to be a duplicate. |
I'm seeing the same issue (in my case the extension has a debugger registered in the
And later the call:
fails with:
Windows 10 |
As a note, downgrading VSCode to 1.53.2 also works for me (so, it seems like a regression in the latest release). |
Here is my analysis of the issue: The error occurs because a check in the extension API fails that verifies that a "debug adapter factory" can only be registered in the extension that defines the corresponding "debugger". The error occurs here: vscode/src/vs/workbench/api/common/extHostDebugService.ts Lines 328 to 330 in d574f8e
Here is the code of the "check": vscode/src/vs/workbench/api/common/extHostDebugService.ts Lines 745 to 760 in d574f8e
An example context where this check fails can be seen above in this #118562 (comment): A debugger with type "robotframework-lsp" is defined in the package.json and in the extension's activation code a debug adapter factory is registered for the same type "robotframework-lsp" with the call The check fails which means that the This check exists for a long time and never failed for any other reason than the one it was introduced for. I'm not aware of any changes in debug land that could cause this (there were no changes in that area). Until now, this issue was only reported for Windows. @alexdima @sandy081 @bpasero @isidorn are you aware of anything related to this? |
Thank you @weinand , that helped to point in the right direction. Looking again at the full logs contained in the original issue, the problem is that the @jrieken It looks like an uppercase/lowercase problem ( Relevant lines:
Full relevant logs:
|
Maybe the same as https://github.com/microsoft/vscode-remote-release/issues/4602. I don't recall any changes and the code that builds the extension tree is quite old (mature). However, we did change the node version this milestone and maybe some things around realPath have changed |
@michalfita thanks for reporting. This is a very interesting issue. A few questions
|
In this case they were launched from the Start menu eventually a new windows from inside already running vscode if that matters. |
There is indeed electron minor version bump from To rule out runtime effects, I updated So this is purely a regression on our app code, performing a git bisect now. |
|
This is a fun one, the problematic call was the conversion from
|
According to the docs, the promise version of |
👏 |
@deepak1556 great work, thanks a lot! |
wow, nice find @deepak1556 |
This fix has been pushed to |
The fix for this should also fix the following issues:
And maybe:
|
@AnrDaemon no, those two issues preceded the commit that resulted in this regression. |
Whoa, has an issue been filed with node? That |
More information here: microsoft/vscode-cpptools#7114
I want to highlight this from the customer's logs. They are trying to load the
ms-vscode.cpptools
extension, but the reasoning in the log does not make sense becausems-vscode.cpptools
registers the'cppvsdbg'
debugger type). Downgrading VS Code to 1.53.2 fixes the issue for the customer. We're not sure what would cause this.Does this issue occur when all extensions are disabled?: No
The text was updated successfully, but these errors were encountered: