Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use older way of launching debugger when using conda less than 4.9.0 #18451

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

karthiknadig
Copy link
Member

For #18436

@karthiknadig karthiknadig added the skip tests Updates to tests unnecessary label Feb 4, 2022
@karthiknadig karthiknadig self-assigned this Feb 4, 2022
Copy link

@paulacamargo25 paulacamargo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@karthiknadig karthiknadig merged commit 3b114e3 into microsoft:main Feb 7, 2022
@karthiknadig karthiknadig deleted the fix-debugging branch February 7, 2022 18:38
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Feb 7, 2022
karthiknadig added a commit that referenced this pull request Feb 10, 2022
* Fix conda run output marker script (#18412) (#18413)

* Fix marker script support for '-c' flag (#18418)

* Fix the interpreter selected by 'new venv' prompt (#18417)

* Update version and changelog for release (#18421)

* Use older way of launching debugger when using conda less than 4.9.0 (#18451)

* CI failures: Pin prospector to 1.6.0, pytest to < 7.0.0, and fix linting issues with flake8 3.9.2 (#18446)

* See if pinning pip works

* Pin in pr check

* Pin pip everywhere else

* angery

* Undo pip changes

* Pin pytest < 7.0.0

* Fix linting?

* Update release version and change log for point release (#18470)

* Update release version and change log for point release

* update changelog

* Fix `invalid patch string` error when using conda (#18481)

* Fix `invalid patch string` error when using conda

* Fix tests

* Update change log

* Cleanup news files

Co-authored-by: Kartik Raj <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
@sfaroy
Copy link

sfaroy commented Feb 24, 2022

Hi @karthiknadig ,

Maybe it would be good to use the old way for also debugging in linux environment where the conda version is less than 4.12.0 - as the permission bug is fixed only on that version:
conda/conda#10690
conda/conda#11208

Can this be done?

@karthiknadig
Copy link
Member Author

/cc @karrtikr

wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
* Fix conda run output marker script (microsoft/vscode-python#18412) (microsoft/vscode-python#18413)

* Fix marker script support for '-c' flag (microsoft/vscode-python#18418)

* Fix the interpreter selected by 'new venv' prompt (microsoft/vscode-python#18417)

* Update version and changelog for release (microsoft/vscode-python#18421)

* Use older way of launching debugger when using conda less than 4.9.0 (microsoft/vscode-python#18451)

* CI failures: Pin prospector to 1.6.0, pytest to < 7.0.0, and fix linting issues with flake8 3.9.2 (microsoft/vscode-python#18446)

* See if pinning pip works

* Pin in pr check

* Pin pip everywhere else

* angery

* Undo pip changes

* Pin pytest < 7.0.0

* Fix linting?

* Update release version and change log for point release (microsoft/vscode-python#18470)

* Update release version and change log for point release

* update changelog

* Fix `invalid patch string` error when using conda (microsoft/vscode-python#18481)

* Fix `invalid patch string` error when using conda

* Fix tests

* Update change log

* Cleanup news files

Co-authored-by: Kartik Raj <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants