Cherry pick fix for conda run output marker script into release #18413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
added
no-changelog
karthiknadig
approved these changes
Feb 2, 2022
karthiknadig
reviewed
Feb 2, 2022
Comment on lines
+16
to
+17
| for code in sys.argv[2:]: | ||
| exec(code, ns, ns) |
There was a problem hiding this comment.
This is not doing the right thing when setting the sys.argv for the code execution:
There was a problem hiding this comment.
I'll handle this in another PR!
karthiknadig
added a commit
that referenced
this pull request
Feb 10, 2022
* Fix conda run output marker script (#18412) (#18413) * Fix marker script support for '-c' flag (#18418) * Fix the interpreter selected by 'new venv' prompt (#18417) * Update version and changelog for release (#18421) * Use older way of launching debugger when using conda less than 4.9.0 (#18451) * CI failures: Pin prospector to 1.6.0, pytest to < 7.0.0, and fix linting issues with flake8 3.9.2 (#18446) * See if pinning pip works * Pin in pr check * Pin pip everywhere else * angery * Undo pip changes * Pin pytest < 7.0.0 * Fix linting? * Update release version and change log for point release (#18470) * Update release version and change log for point release * update changelog * Fix `invalid patch string` error when using conda (#18481) * Fix `invalid patch string` error when using conda * Fix tests * Update change log * Cleanup news files Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]>
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
* Fix conda run output marker script (microsoft/vscode-python#18412) (microsoft/vscode-python#18413) * Fix marker script support for '-c' flag (microsoft/vscode-python#18418) * Fix the interpreter selected by 'new venv' prompt (microsoft/vscode-python#18417) * Update version and changelog for release (microsoft/vscode-python#18421) * Use older way of launching debugger when using conda less than 4.9.0 (microsoft/vscode-python#18451) * CI failures: Pin prospector to 1.6.0, pytest to < 7.0.0, and fix linting issues with flake8 3.9.2 (microsoft/vscode-python#18446) * See if pinning pip works * Pin in pr check * Pin pip everywhere else * angery * Undo pip changes * Pin pytest < 7.0.0 * Fix linting? * Update release version and change log for point release (microsoft/vscode-python#18470) * Update release version and change log for point release * update changelog * Fix `invalid patch string` error when using conda (microsoft/vscode-python#18481) * Fix `invalid patch string` error when using conda * Fix tests * Update change log * Cleanup news files Co-authored-by: Kartik Raj <[email protected]> Co-authored-by: Kim-Adeline Miguel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.