Display a warning after deploying a blob trigger to a flex consumption app

package.json

@@ -1088,6 +1088,11 @@
                         "type": "boolean",
                         "description": "%azureFunctions.enableFlexConsumption%",
                         "default": false
+                    },
+                    "azureFunctions.showFlexEventGridWarning": {
+                        "type": "boolean",
+                        "description": "%azureFunctions.showFlexEventGridWarning%",
+                        "default": true
                     }
                 }
             }

package.nls.json

@@ -80,6 +80,7 @@
     "azureFunctions.showDeprecatedStacks": "Show deprecated runtime stacks when creating a Function App in Azure. WARNING: These stacks may be removed at any time and may not be available in all regions.",
     "azureFunctions.showExplorer": "Show or hide the Azure Functions Explorer",
     "azureFunctions.showExtensionsCsprojWarning": "Show a warning when an Azure Functions project was detected that has mismatched \"extensions.csproj\" configuration.",
+    "%azureFunctions.showFlexEventGridWarning%": "Show a warning when deploying a Azure Blob Storage Trigger (using Event Grid) to a Flex Consumption Function App.",
     "azureFunctions.showHiddenStacks": "Show hidden runtime stacks when creating a Function App in Azure. WARNING: These stacks may be in preview or may not be available in all regions.",
     "azureFunctions.showMultiCoreToolsWarning": "Show a warning if multiple installs of Azure Functions Core Tools are detected.",
     "azureFunctions.showProjectWarning": "Show a warning when an Azure Functions project was detected that has not been initialized for use in VS Code.",

src/commands/createFunctionApp/FunctionAppCreateStep.ts

@@ -133,7 +133,7 @@ export class FunctionAppCreateStep extends AzureWizardExecuteStep<IFunctionAppWi
                 version: sku.functionAppConfigProperties.runtime.version
             },
             scaleAndConcurrency: {
-                maximumInstanceCount: context.newFlexInstanceMemoryMB ?? sku.maximumInstanceCount.defaultValue,
+                maximumInstanceCount: context.newFlexMaximumInstanceCount ?? sku.maximumInstanceCount.defaultValue,
                 instanceMemoryMB: context.newFlexInstanceMemoryMB ?? sku.instanceMemoryMB.find(im => im.isDefault)?.size ?? 2048,
                 alwaysReady: [],
                 triggers: null

src/commands/deploy/deploy.ts

@@ -178,7 +178,7 @@ async function deploy(actionContext: IActionContext, arg1: vscode.Uri | string |
         }
     );
 
-    await notifyDeployComplete(context, node, context.workspaceFolder);
+    await notifyDeployComplete(context, node, context.workspaceFolder, isFlexConsumption);
 }
 
 async function updateWorkerProcessTo64BitIfRequired(context: IDeployContext, siteConfig: SiteConfigResource, node: SlotTreeItem, language: ProjectLanguage, durableStorageType: DurableBackendValues | undefined): Promise<void> {

src/commands/deploy/notifyDeployComplete.ts

@@ -14,13 +14,23 @@ import { RemoteFunctionsTreeItem } from '../../tree/remoteProject/RemoteFunction
 import { nonNullValue } from '../../utils/nonNull';
 import { uploadAppSettings } from '../appSettings/uploadAppSettings';
 import { startStreamingLogs } from '../logstream/startStreamingLogs';
+import { hasRemoteEventGridBlobTrigger, promptForEventGrid } from './promptForEventGrid';
 
-export async function notifyDeployComplete(context: IActionContext, node: SlotTreeItem, workspaceFolder: WorkspaceFolder): Promise<void> {
+export async function notifyDeployComplete(context: IActionContext, node: SlotTreeItem, workspaceFolder: WorkspaceFolder, isFlexConsumption?: boolean): Promise<void> {
     const deployComplete: string = localize('deployComplete', 'Deployment to "{0}" completed.', node.site.fullName);
     const viewOutput: MessageItem = { title: localize('viewOutput', 'View output') };
     const streamLogs: MessageItem = { title: localize('streamLogs', 'Stream logs') };
     const uploadSettings: MessageItem = { title: localize('uploadAppSettings', 'Upload settings') };
 
+    try {
+        const shouldCheckEventSystemTopics = isFlexConsumption && await hasRemoteEventGridBlobTrigger(context, node);
+        if (shouldCheckEventSystemTopics) {
+            await promptForEventGrid(context, workspaceFolder);
+        }
+    } catch (err) {
+        // ignore this error, don't block deploy for this check
+    }
+
     // Don't wait
     void window.showInformationMessage(deployComplete, streamLogs, uploadSettings, viewOutput).then(async result => {
         await callWithTelemetryAndErrorHandling('postDeploy', async (postDeployContext: IActionContext) => {

src/commands/deploy/promptForEventGrid.ts

@@ -0,0 +1,57 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { type FunctionEnvelope } from "@azure/arm-appservice";
+import { DialogResponses, type IActionContext, type IAzureMessageOptions } from "@microsoft/vscode-azext-utils";
+import * as retry from 'p-retry';
+import { type WorkspaceFolder } from "vscode";
+import { localize } from "../../localize";
+import { type IBindingTemplate } from "../../templates/IBindingTemplate";
+import { type SlotTreeItem } from "../../tree/SlotTreeItem";
+import { getWorkspaceSetting, updateWorkspaceSetting } from "../../vsCodeConfig/settings";
+
+export async function hasRemoteEventGridBlobTrigger(context: IActionContext, node: SlotTreeItem): Promise<boolean> {
+    const retries = 3;
+    const client = await node.site.createClient(context);
+
+    const funcs = await retry<FunctionEnvelope[]>(
+        async () => {
+            // Load more currently broken https://github.com/Azure/azure-sdk-for-js/issues/20380
+            const response = await client.listFunctions();
+            const failedToList = localize('failedToList', 'Failed to list functions.');
+
+            // https://github.com/Azure/azure-functions-host/issues/3502
+            if (!Array.isArray(response)) {
+                throw new Error(failedToList);
+            }
+
+            return response;
+        },
+        { retries, minTimeout: 10 * 1000 }
+    );
+
+    return funcs.some(f => {
+        const bindings = (f.config as { bindings: IBindingTemplate[] }).bindings;
+        return bindings.some(b => b.type === 'blobTrigger');
+    });
+}
+
+export async function promptForEventGrid(context: IActionContext, workspaceFolder: WorkspaceFolder): Promise<void> {
+    const showFlexEventGridWarning = await getWorkspaceSetting('showFlexEventGridWarning');
+    if (!showFlexEventGridWarning) {
+        return;
+    }
+
+    const eventGridWarning = localize(
+        'eventGridWarning',
+        `Usage of an Event Grid based blob trigger requires an Event Grid subscription created on an Azure Storage v2 account. If you haven't already, you need to create a Event Grid subscription to complete your deployment.`);
+    const options: IAzureMessageOptions = { learnMoreLink: 'https://aka.ms/learnMoreEventGridSubscription' };
+    // need to add don't show again
+    const result = await context.ui.showWarningMessage(eventGridWarning, options, { title: 'Close' }, DialogResponses.dontWarnAgain);
+    if (result === DialogResponses.dontWarnAgain) {
+        await updateWorkspaceSetting('showFlexEventGridWarning', false, workspaceFolder);
+    }
+
+}