Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a warning after deploying a blob trigger to a flex consumption app #4138

Merged
merged 7 commits into from
May 20, 2024

Conversation

nturinski
Copy link
Member

For Azure Storage Blob Triggers (Using Event Grid) to work on a live Function App, there are further steps that need to be done.

You can read about that here: https://aka.ms/learnMoreEventGridSubscription

This is just an interim solution, but basically we want to let users know about the next steps whenever they deploy a blobTrigger to a flex app.

@nturinski nturinski requested a review from a team as a code owner May 16, 2024 20:12
MicroFish91
MicroFish91 previously approved these changes May 17, 2024
'eventGridWarning',
`Usage of an Event Grid based blob trigger requires an Event Grid subscription created on an Azure Storage v2 account. If you haven't already, you need to create a Event Grid subscription to complete your deployment.`);
const options: IAzureMessageOptions = { learnMoreLink: 'https://aka.ms/learnMoreEventGridSubscription' };
// need to add don't show again
Copy link
Contributor

@MicroFish91 MicroFish91 May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a todo comment?

if (result === DialogResponses.dontWarnAgain) {
await updateWorkspaceSetting('showFlexEventGridWarning', false, workspaceFolder);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Extra new line

@nturinski nturinski disabled auto-merge May 20, 2024 18:37
@nturinski nturinski merged commit fce8ac1 into main May 20, 2024
1 of 2 checks passed
@nturinski nturinski deleted the nat/eventGridDeployPrompt branch May 20, 2024 18:37
@nturinski nturinski added this to the 1.15.0 milestone May 21, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants