[OpenFX] New Port

[ramajd]

• Changes comply with the maintainer guide.
• The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
• Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
• The versioning scheme in vcpkg.json matches what upstream says.
• The license declaration in vcpkg.json matches what upstream says.
• The installed as the "copyright" file matches what upstream says.
• The source code of the component installed comes from an authoritative source.
• The generated "usage text" is accurate. See adding-usage for context.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is in the new port's versions file.
• Only one version is added to each modified port's versions file.

[ramajd]

since the previous pull request for OpenFX library (#36927) didn't have any progress since last month, I submitted a new one by myself.

in my opinion the current PR is ready to be merged. however, if any further changes need to be applied, please let me know.

[ramajd]

@microsoft-github-policy-service agree

[ramajd]

@BillyONeal I just extracted the CMake files from the patch to separated files copied using the file(COPY_FILE ...)

[ramajd]

@WangWeiLin-MV I just marked the CMake target as unofficial . the usage document is also added to the port

[BillyONeal]

@BillyONeal I just extracted the CMake files from the patch to separated files copied using the file(COPY_FILE ...)

Thanks! If you think it's ready to go please push the

button :)

[ramajd]

@WangWeiLin-MV I applied all the changes except OFX_SUPPORT_PLUGINS_HEADERS_DIR which is not related to the main SDK header file and only used in examples.

[WangWeiLin-MV]

Since it is a new port, could you please change files End of Line to LF? Thanks in advance.

[dg0yt]

the version 1.4 is currently used in host applications like Davinci Resolve. so at least we need that version available for now. we can add the latest releases with CMake support included afterwards.

So the CMake project must be reviewed...
I wonder what is the purpose of having two targets, OpenFx and OfxSupport. Does it mirror HEAD's build system?

[ramin-raeisi]

the version 1.4 is currently used in host applications like Davinci Resolve. so at least we need that version available for now. we can add the latest releases with CMake support included afterwards.

So the CMake project must be reviewed... I wonder what is the purpose of having two targets, OpenFx and OfxSupport. Does it mirror HEAD's build system?

@dg0yt @WangWeiLin-MV

OfxSupport composed of C++ wrappers for OpenFx as, OpenFx is C-based.

[WangWeiLin-MV]

Port usage tests pass with following triplets:

• x64-linux
• x64-windows
• x64-windows-static
• x64-windows-static-md
• x86-windows

[dg0yt]

Community feedback.

[dg0yt]

I would suggest to merge the contests of the other short file, and then rename this file to CMakeLists.txt.

[dg0yt]

I think that this is mostly obsolete, given the target_compile_feature below.

Suggested change

	set(CMAKE_CXX_STANDARD 11)
	set(CMAKE_CXX_STANDARD_REQUIRED ON)

[ramajd]

@dg0yt since OpenFX support library can't be built using the C++17, we should stick to C++14, at least for this old version. so I just updated the CMAKE_CXX_STANDARD to 14.

[BillyONeal]

I'm happy with this provided the issues raised by @dg0yt are addressed/considered

[ramajd]

@dg0yt @BillyONeal I just applied the changes related to the provided feedbacks.

[JavierMatosD]

Please follow @dg0yt's suggestion here. I'll put the PR in draft for now. When the PR is ready please mark as ready for review.

[ramajd]

@JavierMatosD I applied the mentioned changes, now the PR can be reviewed again