-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg_find_acquire_program(NINJA).cmake] Update to 1.11.1 #34750
[vcpkg_find_acquire_program(NINJA).cmake] Update to 1.11.1 #34750
Conversation
Implements #34433 (comment). |
It looks like the CI succeeded so I imagine this should be fine. Note: I came across additional discrepancies between my CI and Dev so this change may not be necessary to fix errors, but here all the same. |
Please fix the conflict and CI error. |
4299ad0
to
b002186
Compare
b002186
to
8bc1bac
Compare
Please get failure logs here. Please ping me if you need any help. |
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
@Adela0814 These look like intermittent network failures to me, is there a way to re-run just those jobs? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
It looks like the failures are due to Windows build machine timeouts. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
1.12.0 seems to be more attractive: |
|
Hi there, thanks for the update. I'm closing this in favor of the other PR which updates to 1.12. (Which I also have to resurrect :) ) |
./vcpkg x-add-version --all
and committing the result.I was getting some build discrepancies between my CI builds, which use this ninja, and my dev builds, which use the ninja that comes with Visual Studio which uses version
1.11.1
.I might not have the time to progress this from the draft stage if many ports need fixes, but we'll see.