Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ninja] update to v1.11.1 #34433

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[ninja] update to v1.11.1 #34433

merged 1 commit into from
Oct 13, 2023

Conversation

honeway
Copy link
Contributor

@honeway honeway commented Oct 12, 2023

No description provided.

@honeway
Copy link
Contributor Author

honeway commented Oct 12, 2023 •
edited
Loading

@microsoft-github-policy-service agree

@jimwang118 jimwang118 added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines labels Oct 12, 2023
@BillyONeal
Copy link
Member

This intentionally used an older one because we didn't want to force users to go out of their way to get an updated copy unless there's a specific change we need. This means the distro copies don't work when they do work for the vast majority of linux distros:

vcpkg dependencies table

Is there a specific change you believe we need from 1.11.1?

@BillyONeal BillyONeal added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed info:reviewed Pull Request changes follow basic guidelines labels Oct 13, 2023
@honeway
Copy link
Contributor Author

honeway commented Oct 13, 2023 •
edited
Loading

@BillyONeal The URL of ninja on the freebsd platform cannot be accessed. I found that cmake had a similar change in release 2023.08.09, updating to 3.27.1 and removing support for freebsd. So updating ninja too.

@BillyONeal
Copy link
Member

@BillyONeal The URL of ninja on the freebsd platform cannot be accessed. I found that cmake had a similar change, updating to 3.27.1 and removing support for freebsd.

Can you link to that?

What's wrong with 1.10.0 on *nix?

@honeway
Copy link
Contributor Author

honeway commented Oct 13, 2023

@BillyONeal The URL of ninja on the freebsd platform cannot be accessed. I found that cmake had a similar change, updating to 3.27.1 and removing support for freebsd.

Can you link to that?

What's wrong with 1.10.0 on *nix?

ninja-build/ninja#2173

@xavier2k6
Copy link
Contributor

xavier2k6 commented Oct 13, 2023 •
edited
Loading

@BillyONeal The URL of ninja on the freebsd platform cannot be accessed. I found that cmake had a similar change, updating to 3.27.1 and removing support for freebsd.

Can you link to that?

#31931 (comment)

@BillyONeal BillyONeal merged commit 86538c1 into microsoft:master Oct 13, 2023
@BillyONeal
Copy link
Member

Thanks for explaining the situation!

@BillyONeal BillyONeal removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Oct 13, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Oct 13, 2023

Does vcpkg_find_acquire_program need to be updated, too?

@honeway honeway deleted the p-update-ninja branch October 14, 2023 01:06
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Oct 16, 2023
clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
@honeway @clementperon
[ninja] update to v1.11.1 (microsoft#34433)
0ef6920
@dg0yt dg0yt mentioned this pull request Oct 27, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@honeway @BillyONeal @xavier2k6 @dg0yt @jimwang118