-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joltphysics] Disable treats all compiler warnings as errors #29271
[joltphysics] Disable treats all compiler warnings as errors #29271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general we should be leaving the warnings in the output but just not failing the build over it.
Ideally the port would be fixed to not inject extra flags that it does not need like this too (so that what comes from the toolchain applies).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In an internal version of MSVC compiler,
joltphysics
install failed with following error:I have confirmed with developer, this change is by design and we need to disable this warning.