Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joltphysics] Disable treats all compiler warnings as errors #29271

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented Jan 30, 2023

In an internal version of MSVC compiler, joltphysics install failed with following error:

D:\buildtrees\joltphysics\src\v2.0.1-76420d93c1.clean\Jolt\Core\Reference.h(115): error C2220: the following warning is treated as an error
D:\buildtrees\joltphysics\src\v2.0.1-76420d93c1.clean\Jolt\Core\Result.h(161): note: see reference to class template instantiation 'JPH::Ref<JPH::Shape>' being compiled
D:\buildtrees\joltphysics\src\v2.0.1-76420d93c1.clean\Jolt\Physics\Collision\Shape\Shape.h(137): note: see reference to class template instantiation 'JPH::Result<JPH::Ref<JPH::Shape>>' being compiled
D:\buildtrees\joltphysics\src\v2.0.1-76420d93c1.clean\Jolt\Core\Reference.h(115): warning C5266: 'const' qualifier on return type has no effect
D:\buildtrees\joltphysics\src\v2.0.1-76420d93c1.clean\Jolt\Core\Reference.h(115): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings

I have confirmed with developer, this change is by design and we need to disable this warning.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 30, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 30, 2023
@LilyWangLL LilyWangLL marked this pull request as ready for review January 30, 2023 08:08
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jan 30, 2023
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general we should be leaving the warnings in the output but just not failing the build over it.

Ideally the port would be fixed to not inject extra flags that it does not need like this too (so that what comes from the toolchain applies).

@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 31, 2023
@LilyWangLL LilyWangLL changed the title [joltphysics] Disable warning C5266 [joltphysics] Disable treats all compiler warnings as errors Jan 31, 2023
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 31, 2023
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BillyONeal BillyONeal merged commit 0a8ac2f into microsoft:master Jan 31, 2023
@LilyWangLL LilyWangLL deleted the dev/LilyWang/CI_unstable_0129 branch March 2, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants