Skip to content

Commit

Permalink
[joltphysics] Disable treats all compiler warnings as errors (#29271)
Browse files Browse the repository at this point in the history
* [joltphysics] Disable warning C5266

* update version

* apply suggestion

* update version
  • Loading branch information
LilyWangLL authored Jan 31, 2023
1 parent b4f29c5 commit 0a8ac2f
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 4 deletions.
13 changes: 13 additions & 0 deletions ports/joltphysics/disable-warningC5266.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/Build/CMakeLists.txt b/Build/CMakeLists.txt
index 27c4c64..78f3947 100644
--- a/Build/CMakeLists.txt
+++ b/Build/CMakeLists.txt
@@ -53,7 +53,7 @@ if (("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows" OR "${CMAKE_SYSTEM_NAME}" STREQUA
endif()

# Set general compiler flags
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /std:c++17 /Zc:__cplusplus /Gm- /Wall /WX /MP /nologo /diagnostics:classic /FC /fp:except- /Zc:inline /Zi")
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /std:c++17 /Zc:__cplusplus /Gm- /Wall /WX- /MP /nologo /diagnostics:classic /FC /fp:except- /Zc:inline /Zi")

# Remove any existing compiler flag that enables RTTI
string(REPLACE "/GR" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
6 changes: 4 additions & 2 deletions ports/joltphysics/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO jrouwe/JoltPhysics
REF v2.0.1
REF "v${VERSION}"
SHA512 c5848fe7a28de1b34259d3d21e4cd35bec4002eee926445e05d902934c43ab4cafcfa24ceb037c59cc66c3dcea5f3a737546f88c20be594dafe6ce6d1f637abb
HEAD_REF master
PATCHES
disable-warningC5266.patch
)

string(COMPARE EQUAL "${VCPKG_CRT_LINKAGE}" "static" USE_STATIC_CRT)
Expand Down Expand Up @@ -43,4 +45,4 @@ else()
endif()

file(INSTALL "${CMAKE_CURRENT_LIST_DIR}/usage" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}")
file(INSTALL "${SOURCE_PATH}/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright)
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")
2 changes: 1 addition & 1 deletion ports/joltphysics/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "joltphysics",
"version": "2.0.1",
"port-version": 1,
"port-version": 2,
"description": "A multi core friendly rigid body physics and collision detection library suitable for games and VR applications",
"homepage": "https://github.com/jrouwe/JoltPhysics",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -3262,7 +3262,7 @@
},
"joltphysics": {
"baseline": "2.0.1",
"port-version": 1
"port-version": 2
},
"josuttis-jthread": {
"baseline": "2020-07-21",
Expand Down
5 changes: 5 additions & 0 deletions versions/j-/joltphysics.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "845755ddfb9fa5d6f88c836cffdb1f497e69ad46",
"version": "2.0.1",
"port-version": 2
},
{
"git-tree": "5e739c5e65a72603e92f5ca31b07a8a78a918166",
"version": "2.0.1",
Expand Down

0 comments on commit 0a8ac2f

Please sign in to comment.