[lz4] depends on xxhash

[autoantwort]

Fixes #28747

[Neumann-A]

You forgot to add the find_dependency call in the lz4-config.cmake.
You also might want to add a #pragma comment(lib, <xxhashlib>) to one of the main headers to simply autolink. Don't know if gcc has something similar.

[autoantwort]

You forgot to add the find_dependency call in the lz4-config.cmake.

Can I also do that with

install(EXPORT lz4Config
  FILE lz4-config.cmake
  NAMESPACE lz4::
  DESTINATION "${INSTALL_CMAKE_DIR}"
)

[Neumann-A]

Can I also do that with

only by reading that file from the portfile and adding the lines at the top.

[dg0yt]

You also might want to add a #pragma comment(lib, <xxhashlib>) to one of the main headers to simply autolink. Don't know if gcc has something similar.

This exists only in MSVC.

AFAICT lz4 would use the vendored xxhash with a specific name prefix (at least if not using vcpkg's vendored build system). As immediate fix, it would have been enough to not install this header. As another step, consider upstream's optional meson build.

[Neumann-A]

As another step, consider upstream's optional meson build.

Probably easier and gets rid of the CMakeLists.txt vendored by vcpkg.

[dg0yt]

@vicroms We need this one merged ASAP. Baseline regression.

[FrankXie05]

Temporarily merging it to fix issues with baseline.