Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg_execute_build_process.cmake: Check if the exit code is a string #28405

Merged
merged 2 commits into from
Jan 12, 2023
Merged

vcpkg_execute_build_process.cmake: Check if the exit code is a string #28405

merged 2 commits into from
Jan 12, 2023

Conversation

autoantwort
Copy link
Contributor

I noticed it while building #28404. Before this change I only got the following error:

Installing 1/1 ace:arm64-osx...
Building ace[core,xml]:arm64-osx...
warning: -- Using community triplet arm64-osx. This triplet configuration is not guaranteed to succeed.
-- [COMMUNITY] Loading triplet configuration from: /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/triplets/community/arm64-osx.cmake
-- Using cached ACE-src-7.0.10.tar.gz.
-- Extracting source /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/downloads/ACE-src-7.0.10.tar.gz
-- Using source at /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/ace/src/ACE-src-7-9d42d4c958.clean
-- Building arm64-osx-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:58 (file):
  file failed to open for reading (No such file or directory):

    /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/ace/make-xml-arm64-osx-dbg-out.log
Call Stack (most recent call first):
  ports/ace/portfile.cmake:336 (vcpkg_execute_build_process)
  scripts/ports.cmake:147 (include)

which is completely misleading (and wrong).
Now you get:

Installing 1/1 ace:arm64-osx...
Building ace[core,xml]:arm64-osx...
warning: -- Using community triplet arm64-osx. This triplet configuration is not guaranteed to succeed.
-- [COMMUNITY] Loading triplet configuration from: /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/triplets/community/arm64-osx.cmake
-- Using cached ACE-src-7.0.10.tar.gz.
-- Cleaning sources at /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/ace/src/ACE-src-7-9d42d4c958.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/downloads/ACE-src-7.0.10.tar.gz
-- Using source at /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/ace/src/ACE-src-7-9d42d4c958.clean
-- Building arm64-osx-dbg
-- Building arm64-osx-dbg done
-- Packaging arm64-osx-dbg
-- Packaging arm64-osx-dbg done
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:58 (message):
  Failed to execute command "make static_libs_only=1 realclean" in working
  directory
  "/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/ace/src/ACE-src-7-9d42d4c958.clean/ace/ACEXML":
  No such file or directory
Call Stack (most recent call first):
  ports/ace/portfile.cmake:373 (vcpkg_execute_build_process)
  scripts/ports.cmake:147 (include)

github-actions[bot]
github-actions bot previously approved these changes Dec 18, 2022
View reviewed changes
@Cheney-W Cheney-W added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Dec 19, 2022
@autoantwort
Copy link
Contributor Author

These errors must be baseline regressions

@Cheney-W
Copy link
Contributor

Yes, we are fixing them.

@autoantwort autoantwort force-pushed the check-if-exit-code-string branch from 1d745ad to bd67100 Compare December 21, 2022 15:48
github-actions[bot]
github-actions bot previously approved these changes Dec 30, 2022
View reviewed changes
@autoantwort autoantwort force-pushed the check-if-exit-code-string branch from c46584e to 75fd856 Compare January 5, 2023 13:03
@autoantwort
Copy link
Contributor Author

Depends on #28748

@autoantwort
Copy link
Contributor Author

@Cheney-W You can review :)

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jan 11, 2023
@vicroms vicroms merged commit 0960ce8 into microsoft:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autoantwort @Cheney-W @vicroms