Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dcmtk] re-enable support on arm64-osx #27611

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

kevle
Copy link
Contributor

@kevle kevle commented Nov 2, 2022

Describe the pull request

  • What does your PR fix?

    Re-enables dcmtk build on arm64-osx

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    arm64-osx is a community triplet and not applicable to ci.baseline.txt from what I can tell.
    arm64-windows and arm-uwp still fail in CI, so support has been excluded for those in the port file
    arm[64]-{android,ios,linux,mingw} etc. are untested, I might be able to test crosscompilation for arm[64]-linux if that is necessary
    Since #23034 explicitly references arm mac, I think this should be ok.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@kevle
Copy link
Contributor Author

kevle commented Nov 2, 2022

@microsoft-github-policy-service agree

@kevle kevle marked this pull request as ready for review November 2, 2022 14:12
@Adela0814 Adela0814 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines labels Nov 3, 2022
@BillyONeal BillyONeal merged commit cdf0a24 into microsoft:master Nov 3, 2022
@BillyONeal
Copy link
Member

Thanks!

@BillyONeal
Copy link
Member

  • Since #23034 explicitly references arm mac, I think this should be ok.

That says that it does not work on arm mac. However it also removed entries from ci.baseline.txt and maybe that was a drive-by. I'm interpreting that you made this PR as "it works for me" so I merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants