[ports] add support expressions #23034
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/apsi/vcpkg.jsonports/bde/vcpkg.jsonports/ctemplate/vcpkg.jsonports/dcmtk/vcpkg.jsonports/embree2/vcpkg.jsonports/tesseract/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
JonLiu1993
added
the
category:port-feature
ports/apsi/vcpkg.json
Outdated
| "description": "APSI is a research library for asymmetric private set intersection.", | ||
| "homepage": "https://github.com/microsoft/APSI", | ||
| "supports": "static", | ||
| "supports": "static & !arm", |
There was a problem hiding this comment.
It does look like the library attempts to support arm & arm64 (https://github.com/microsoft/APSI/blob/main/common/apsi/fourq/FourQ.h#L83), so I don't think !arm is right here.
I did a little bit of investigation and discovered the failure might be due to the flatbuffers dependency, which I've attempted to address #23067.
Could you leave this change off of this PR?
There was a problem hiding this comment.
On my arm macbook I get the following error:
CMake Error at common/apsi/fourq/CMakeLists.txt:30 (add_subdirectory):
add_subdirectory given source "arm64" which is not an existing directory.
That indicated it does not support arm, at least not on mac.
There was a problem hiding this comment.
Ok I have removed apsi from this PR. @JonLiu1993 you can mark this as reviewed again :)
JonLiu1993
removed
the
info:reviewed
JonLiu1993
added
depends:upstream-changes
autoantwort
force-pushed
the
add-support-expressions
branch
from
b222268 to
cbc92ea
Compare
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/bde/vcpkg.jsonports/ctemplate/vcpkg.jsonports/dcmtk/vcpkg.jsonports/embree2/vcpkg.jsonports/tesseract/vcpkg.json
Valid values for the license field can be found in the documentation
JonLiu1993
removed
the
depends:upstream-changes
|
Now that #23067 is merged, can you try again and let us know how it goes? |
JonLiu1993
removed
the
info:reviewed
autoantwort
force-pushed
the
add-support-expressions
branch
from
cbc92ea to
ecf060f
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for brpc but no changes to version or port version.
-- Version: 0.9.7#6
-- Old SHA: f658cec9384935d01319d2725a039da7cb5e6c77
-- New SHA: 4546ed4f98a6739ff14ba5c6f0291696ad837ac2
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/bde/vcpkg.jsonports/ctemplate/vcpkg.jsonports/dcmtk/vcpkg.jsonports/embree2/vcpkg.jsonports/tesseract/vcpkg.json
Valid values for the license field can be found in the documentation
autoantwort
force-pushed
the
add-support-expressions
branch
from
ecf060f to
6149495
Compare
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/apsi/vcpkg.jsonports/bde/vcpkg.jsonports/ctemplate/vcpkg.jsonports/dcmtk/vcpkg.jsonports/embree2/vcpkg.jsonports/tesseract/vcpkg.json
Valid values for the license field can be found in the documentation
|
apsi still does not build on arm64-osx. So I added the support expression back for macOS |
|
Trigger CLA check again |
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/apsi/vcpkg.jsonports/bde/vcpkg.jsonports/ctemplate/vcpkg.jsonports/dcmtk/vcpkg.jsonports/embree2/vcpkg.jsonports/tesseract/vcpkg.json
Valid values for the license field can be found in the documentation
Tested them on my arm mac and they don't support arm.