Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Update the minimum version of vcpkg #18695

Closed
wants to merge 1 commit into from
Closed

[vcpkg] Update the minimum version of vcpkg #18695

wants to merge 1 commit into from

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jun 29, 2021 •
edited
Loading

Since microsoft/vcpkg and microsoft/vcpkg-tool are synchronized to update x-download related content, update to 2021-05-05 (contains x-download) version to avoid being unable to find this command:

E:\Lib\vcpkg>vcpkg install sundials --triplet x64-windows
Computing installation plan...
The following packages will be built and installed:
    sundials[core]:x64-windows -> 5.7.0#1
Detecting compiler hash for triplet x64-windows...
Could not locate cached archive: C:\Users\ch6535\AppData\Local\vcpkg\archives\df\df61b63fc4d86a443bbedaa77be748372df4bfe
c.zip
Starting package 1/1: sundials:x64-windows
Building package sundials[core]:x64-windows...
-- Downloading https://github.com/LLNL/sundials/archive/73c280cd55ca2b42019c8a9aa54af10e41e27b9d.tar.gz -> LLNL-sundials
-73c280cd55ca2b42019c8a9aa54af10e41e27b9d.tar.gz...
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'manifests' = off
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
[DEBUG] BuiltinRegistry initialized with: ""
[DEBUG] Using vcpkg-root: E:\Lib\vcpkg
[DEBUG] Using installed-root: E:\Lib\vcpkg\installed
[DEBUG] BuiltinRegistry initialized with: ""
[DEBUG] Using buildtrees-root: E:\Lib\vcpkg\buildtrees
[DEBUG] Using downloads-root: E:\Lib\vcpkg\downloads
[DEBUG] Using packages-root: E:\Lib\vcpkg\packages
[DEBUG] Using scripts-root: E:\Lib\vcpkg\scripts
[DEBUG] Using ports-root: E:\Lib\vcpkg\ports
[DEBUG] Using versions-root: E:\Lib\vcpkg\versions
invalid command: x-download

Related: #13639 (comment) #18353 etc.

@JackBoosY JackBoosY added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. labels Jun 29, 2021
@JackBoosY JackBoosY requested a review from PhoebeHui June 29, 2021 07:52
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 2, 2021
@dg0yt dg0yt mentioned this pull request Jul 3, 2021
Closed
@JackBoosY JackBoosY linked an issue Jul 5, 2021 that may be closed by this pull request
[libogg] build failure: invalid command: x-download #18791
Closed
@JackBoosY JackBoosY mentioned this pull request Jul 5, 2021
Merged
@JackBoosY
Copy link
Contributor Author

Waiting for #18812 merge.

@strega-nil-ms strega-nil-ms mentioned this pull request Jul 6, 2021
Merged
@strega-nil-ms
Copy link
Contributor

Closed for rollup PR #18838

@JackBoosY JackBoosY deleted the dev/jack/update_vcpkg_min_ver_20210629 branch July 7, 2021 02:04
@JackBoosY
Copy link
Contributor Author

@strega-nil-ms I suggest to merge this PR quickly since many user have this issue.

@JackBoosY JackBoosY restored the dev/jack/update_vcpkg_min_ver_20210629 branch July 7, 2021 02:05
strega-nil-ms pushed a commit to strega-nil/vcpkg that referenced this pull request Jul 13, 2021
@strega-nil
[rollup:2021-07-06 7/8] PR microsoft#18695 (@JackBoosY)
959d5fa 
[vcpkg] Update the minimum version of vcpkg
BillyONeal pushed a commit that referenced this pull request Jul 14, 2021
@strega-nil-ms @strega-nil @ras0219
[rollup:2021-07-06] Rollup PR (#18838)
d369df7 
* [rollup:2021-07-06 1/8] PR #18272 (@strega-nil)

[scripts-audit] vcpkg_from_*

* [rollup:2021-07-06 2/8] PR #18319 (@strega-nil)

[scripts-audit] add guidelines for cmake

* [rollup 2021-07-06 3/8] PR #18410 (@mheyman)

[vcpkg-cmake-config] documentation fix

* [rollup:2021-07-06 4/8] PR #18488 (@strega-nil)

[scripts-audit] vcpkg_execute_*

* [rollup:2021-07-06 5/8] PR #18517 (@strega-nil)

[scripts-audit] vcpkg_extract_source_archive

* [rollup:2021-07-06 6/8] PR #18674 (@NancyLi1013)

[vcpkg doc] Update examples

* [rollup:2021-07-06 7/8] PR #18695 (@JackBoosY)

[vcpkg] Update the minimum version of vcpkg

* [rollup:2021-07-06 8/8] PR #18758 (@ras0219-msft)

[vcpkg_from_git] Fix error if downloads folder does not exist

* build docs!

* fix bond:*-windows

* fix nmap

Co-authored-by: nicole mazzuca <[email protected]>
Co-authored-by: Michael Heyman <[email protected]>
Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: JackBoosY <[email protected]>
Co-authored-by: Robert Schumacher <[email protected]>
@JackBoosY JackBoosY deleted the dev/jack/update_vcpkg_min_ver_20210629 branch July 15, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libogg] build failure: invalid command: x-download
3 participants
@JackBoosY @strega-nil-ms @PhoebeHui