[vcpkg-cmake-config] documentation fix #18410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
added
the
category:port-bug
|
@mheyman, could you apply the following patch, and submit the changes again? the vcpkg-cmake-config/vcpkg_cmake_config_fixup.md needs update as well. |
PhoebeHui
changed the title
Hoikas
reviewed
Jun 15, 2021
ports/vcpkg-cmake-config/vcpkg.json
Outdated
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "name": "vcpkg-cmake-config", | |||
| "version-date": "2021-05-22" | |||
| "version-date": "2021-06-12" | |||
There was a problem hiding this comment.
Since this is not a change to the port's functionality, this should leave the version-date identical and bump the port-version to 1 instead, IMO.
|
Will do - I forgot about |
|
Closed for rollup PR #18838 |
strega-nil-ms
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
Jul 9, 2021
[vcpkg-cmake-config] documentation fix
BillyONeal
pushed a commit
that referenced
this pull request
Jul 14, 2021
* [rollup:2021-07-06 1/8] PR #18272 (@strega-nil) [scripts-audit] vcpkg_from_* * [rollup:2021-07-06 2/8] PR #18319 (@strega-nil) [scripts-audit] add guidelines for cmake * [rollup 2021-07-06 3/8] PR #18410 (@mheyman) [vcpkg-cmake-config] documentation fix * [rollup:2021-07-06 4/8] PR #18488 (@strega-nil) [scripts-audit] vcpkg_execute_* * [rollup:2021-07-06 5/8] PR #18517 (@strega-nil) [scripts-audit] vcpkg_extract_source_archive * [rollup:2021-07-06 6/8] PR #18674 (@NancyLi1013) [vcpkg doc] Update examples * [rollup:2021-07-06 7/8] PR #18695 (@JackBoosY) [vcpkg] Update the minimum version of vcpkg * [rollup:2021-07-06 8/8] PR #18758 (@ras0219-msft) [vcpkg_from_git] Fix error if downloads folder does not exist * build docs! * fix bond:*-windows * fix nmap Co-authored-by: nicole mazzuca <[email protected]> Co-authored-by: Michael Heyman <[email protected]> Co-authored-by: NancyLi1013 <[email protected]> Co-authored-by: JackBoosY <[email protected]> Co-authored-by: Robert Schumacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes mistake in vcpkg_cmake_config_fixup example: It said
DO_NOT_DELETE_CONFIG_PATH_PARENTwhen it should have saidDO_NOT_DELETE_PARENT_CONFIG_PATH.Which triplets are supported/not supported? Have you updated the CI baseline?
All. No need.
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/