[ffmpeg] soxr dependency fix #17299
Merged
[ffmpeg] soxr dependency fix #17299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wrong base branch. 😄 Rebasing... |
NancyLi1013
added
the
category:port-bug
mcmtroffaes
force-pushed
the
feature/soxr-dependency-fix
branch
from
fa4c78c to
030188d
Compare
|
Ok, should be good now. |
NancyLi1013
approved these changes
Apr 15, 2021
|
LGTM, let's wait for the CI checks. |
|
@mcmtroffaes You are a rock star ;-) |
|
Seems to solve the conflicts @mcmtroffaes. |
|
I'll wait for #17204 to get merged before solving the conflicts, if that's ok? |
Sure, No problem. |
NancyLi1013
added
the
depends:different-pr
mcmtroffaes
force-pushed
the
feature/soxr-dependency-fix
branch
from
030188d to
a43d502
Compare
|
Rebased. |
NancyLi1013
added
info:reviewed
mcmtroffaes
force-pushed
the
feature/soxr-dependency-fix
branch
from
a43d502 to
5e4148f
Compare
|
Rebased & conflicts resolved. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mcmtroffaes
force-pushed
the
feature/soxr-dependency-fix
branch
from
5e4148f to
298c120
Compare
|
Rebased & resolved conflicts. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
sthagen
added a commit
to sthagen/microsoft-vcpkg
that referenced
this pull request
May 4, 2021
[ffmpeg] soxr dependency fix (microsoft#17299)
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
May 4, 2021
[ffmpeg] soxr dependency fix (microsoft#17299)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes [ffmpeg] fails to detect soxr #17270
Which triplets are supported/not supported? Have you updated the CI baseline?
Triplets unchanged, baseline updated.
Does your PR follow the maintainer guide?
Yes to the best of my knowledge.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.