Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffmpeg] add usage #17284

Merged
merged 18 commits into from
May 21, 2021
Merged

[ffmpeg] add usage #17284

merged 18 commits into from
May 21, 2021

Conversation

autoantwort
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    How to use ffmpeg (see discussion on discord)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    I am still working on this PR

After #17153, #17204 and #17236 are merged, I will run ./vcpkg x-add-version --all.

@longnguyen2004
Copy link
Contributor

Probably no need for x-add-version since we're just merely adding a USAGE file.

@autoantwort
Copy link
Contributor Author

Probably no need for x-add-version since we're just merely adding a USAGE file.

Yeah that is right, but I don't know if that is allowed

@JonLiu1993 JonLiu1993 self-assigned this Apr 15, 2021
@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 15, 2021
@JonLiu1993
Copy link
Member

@autoantwort ,please run the vcpkg x-add-version ffmpeg --overwrite-version command then commit angin.

Copy link
Member

@JonLiu1993 JonLiu1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@autoantwort ,please set Port-Version: 3 to Port-Version: 4

@longnguyen2004
Copy link
Contributor

@autoantwort I think you should go with this first, since it already LGTM.

@autoantwort autoantwort marked this pull request as ready for review April 30, 2021 18:24
@autoantwort
Copy link
Contributor Author

@autoantwort I think you should go with this first, since it already LGTM.

Ok, done

@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil-ms
Copy link
Contributor

Note to self: merge at same time as #17299

@autoantwort
Copy link
Contributor Author

Note to self: merge at same time as #17299

#17299 has already been merged

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2021
@JonLiu1993 JonLiu1993 removed the info:reviewed Pull Request changes follow basic guidelines label May 7, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 8, 2021
@dan-shaw
Copy link
Contributor

@autoantwort Can you resolve the conflicts?

@JonLiu1993 JonLiu1993 removed the info:reviewed Pull Request changes follow basic guidelines label May 18, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 20, 2021
@dan-shaw dan-shaw merged commit 19b1714 into microsoft:master May 21, 2021
@autoantwort autoantwort deleted the ffmpeg-add-usage branch September 1, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants