-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scripts] vcpkg_configure_make: do not set --build on macOS #16596
Conversation
4410747
to
7e6c8c0
Compare
None of mine, or not in that way. But I have multiple PRs that fix apple silicon builds. |
Hm, but this breaks for example |
hmm gmp seems to be on skip on osx? |
now with the valid cmake script it builds successfully on my machine |
@autoantwort if it works, can you remove the skip in ci.baseline.txt? |
There is no skip on osx for |
gmp with osx and linux skipped by 'supports' which will be fixed by PR #15957. After the PR merged, we should rerun this PR. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
#15957 has been merged |
I can not reproduce the libgnutls build error and x264 did not worked before this change (on my mashine). Maybe simply rerun the pipeline? |
@autoantwort, I have rerun the CI testing. |
The |
The libgnutls:x64-osx failed with following failures:
|
@PhoebeHui yes, this is the issue I was referring to. |
@wrobelda, thanks for confirming this issue! I will submit a PR to disable it. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Can confirm this fixes #16464 for me (nettle x64 build on Apple Silicon) |
This LGTM, thanks everyone! |
Describe the pull request
See last discussion on #16595