[many ports] Add GnuTLS and its dependencies #14242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangL
added
the
category:new-port
This comment has been minimized.
This comment has been minimized.
|
@odskinz488 You can open a new PR, inherit these changes and continue. |
|
Pinging @wrobelda for response. Is work still being done for this PR? |
|
@JackBoosY I intend to finish this work, got held back by migrating to Apple Silicon last month. |
|
@JackBoosY ready for review. Linux only, for now. |
|
@JackBoosY I just got it to work on macOS, about to commit those changes EDIT: done |
JackBoosY
suggested changes
Mar 1, 2021
|
@JackBoosY the CI build is being skipped for |
|
@wrobelda Because libgnutls dependency can't be built on OSX now. |
JackBoosY
suggested changes
Mar 1, 2021
JackBoosY
approved these changes
Mar 1, 2021
JackBoosY
approved these changes
Mar 9, 2021
|
This LGTM, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a port for GnuTLS library and its dependencies.
Which triplets are supported/not supported? Have you updated the CI baseline?
x64-linux only, for now. Yes.
Does your PR follow the maintainer guide?
Yes