-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metrohash] support more triplets by excluding 128 CRC source #16553
Conversation
* the change will allow x86 triplets * update port SHA
* update ci.baseline.txt
* make both file use 'VCPKG_TARGET_TRIPLET' to make ease of comparison
Feels like my team is the only one who is using this port 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luncliff, thanks for the PR!
@ras0219-msft, could you help further review?
@ras0219-msft Thanks for the 1c8c750, I will check the port within days. :) |
Works as expected for |
What does your PR fix?
Make
metrohash
support more triplets, which are not available because of_mm_crc32_u64
intrinsicVCPKG_TARGET_ARCHITECTURE
to exclude source file that uses_mm_crc32_u64
Previous Work
Which triplets are supported/not supported? Have you updated the CI baseline?
metrohash
related failures are removed from ci.baseline.txt. ARM & UWP triplets become available because there is no more constraint of_mm_crc32_u64
arm64-windows
arm64-uwp
x64-uwp
Does your PR follow the maintainer guide?
I thought we can create a patch for the header file,
metrohash.h
. It can add some macro checks like the following.I decided to remain simple for now but I'd like to hear about replacing
vcpkg_replace_string
with a patch like it.