Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrohash] support iOS triplets #16035

Merged
merged 4 commits into from
Feb 9, 2021
Merged

[metrohash] support iOS triplets #16035

merged 4 commits into from
Feb 9, 2021

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Feb 4, 2021

What does your PR fix?

This is an enhancement of #15715

Which triplets are supported/not supported? Have you updated the CI baseline?

Support 4 ios triplets

  • arm64-ios
  • arm-ios
  • x64-ios
  • x86-ios
$ ./vcpkg install metrohash:arm64-ios metrohash:arm-ios metrohash:x64-ios metrohash:x86-ios
...

The package metrohash:arm-ios provides CMake targets:

    find_package(metrohash CONFIG REQUIRED)
    target_link_libraries(main PRIVATE metrohash::metrohash)

The package metrohash:arm64-ios provides CMake targets:

    find_package(metrohash CONFIG REQUIRED)
    target_link_libraries(main PRIVATE metrohash::metrohash)

The package metrohash:x64-ios provides CMake targets:

    find_package(metrohash CONFIG REQUIRED)
    target_link_libraries(main PRIVATE metrohash::metrohash)

The package metrohash:x86-ios provides CMake targets:

    find_package(metrohash CONFIG REQUIRED)
    target_link_libraries(main PRIVATE metrohash::metrohash)

Does your PR follow the maintainer guide?

Yes

  • Versioning
    • "port-version" update
    • Update the version files in versions/
  • Code format
    • Manifests

@NancyLi1013 NancyLi1013 self-assigned this Feb 5, 2021
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 5, 2021
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Feb 5, 2021
@ras0219-msft
Copy link
Contributor

Sweet, LGTM. Thanks for the fixes!

@ras0219-msft ras0219-msft merged commit 8317bf9 into microsoft:master Feb 9, 2021
@luncliff luncliff deleted the ios/metrohash branch February 15, 2021 03:40
@luncliff luncliff restored the ios/metrohash branch February 15, 2021 03:41
@luncliff luncliff deleted the ios/metrohash branch March 29, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants