-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost] update to 1.75.0 #15090
[boost] update to 1.75.0 #15090
Conversation
Duplicate of #15071 ? |
@cenit Yes. I would like to speed up update. |
@yurybura, thanks for your contribution! Here is CI testing results:
symengine with arm64-windows/arm-uwp
|
…n doesn't support ARM now (boostorg/multiprecision#234 (comment))
As I mentioned in the linked topic, I installed Boost 1.75 on my local machine and Telnet++ compiled and linked just fine with my mainline. So I'm not sure what's causing the problem. Any assistance would be graciously and gratefully received. |
@KazDragon Thank you. I'll check this issue when I can. |
@yurybura Seems interesting, I'll certainly test this for mingw! |
Dear @PhoebeHui, |
x64-osx is having problems like usual, just ignore it for now. |
@yurybura, I have rerun the CI testing with x64-osx. It's in progress. |
recently I experience this behaviour under linux/osx:
as you can see both configs are built twice. Is it solved by this PR? I assume there might be a double loop somewhere Note: this happens only in boost-* libs Note2: it was decided a long time ago to build debug first, to quicken the failure in case of errors. Maybe also an inversion in the configs is required, after the double build is solved |
@cenit That behavior has been there for a long time, and it's due to how the build helper works. |
before https://github.com/microsoft/vcpkg/blob/master/ports/boost-modular-build-helper/boost-modular-build.cmake#L141 and https://github.com/microsoft/vcpkg/blob/master/ports/boost-modular-build-helper/boost-modular-build.cmake#L145 maybe we can set temporarily the VCPKG_BUILD_TYPE if not defined, so that it is not replicated internally? |
@PhoebeHui CI now looks good. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just that each update is going to waste double the time in each and every CI machine using vcpkg and boost... |
Oh wait that's the before so presumably the //s are in what you're replacing. Thanks for your contribution and yay for updated Boost! |
[boost] update to 1.75.0 (microsoft#15090)
The Boost JSON library is compiled, but this adds a header-only portfile for it, so using it doesn't link. I suppose the script that generates the portfiles needs to be patched somehow, but I don't know how. |
The problem is that the script checks for vcpkg/scripts/boost/generate-ports.ps1 Line 398 in 5a10163
but |
Update Boost library to version 1.75.0
Release Notes: https://www.boost.org/users/history/version_1_75_0.html
Adds new libraries/ports: Boost.Json, Boost.Leaf, Boost.Pfr
Removes obsolete library/port Boost.Signals
Fixes #15070