-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build error with Boost 1.75.0 #238
Comments
Hi @yurybura. Thanks for your bug report. This seems to be related to the vcpkg port, which I am not the maintainer for (although I am happy that someone felt it was worthwhile to do so). In fact, I only started supporting MSVC officially as a target a couple of days ago. This looks like some dllimport/dllexport issue. I don't have a huge amount of familiarity with that, so it might take a little while to figure out. Any help would be appreciated |
Ok, it seems that shared libraries do generate a lot of noise, but that isn't what actually broke in the full build linked. That was here:
|
@KazDragon Thank you for your attention to this issue. I would appreciate any help too). |
So I have downloaded and installed Boost 1.75.0 and built Telnet++ against it. It compiled and linked just fine. I cannot reproduce your issue. Does this issue still present itself to you if you are building with static libraries instead of dynamic libraries? |
What is the compiler version you both used? that might explain the differences in behaviour |
I ported Telnet++ to Visual Studio 2019 just last week (whoever did the vcpkg was way ahead of me, and I am grateful to them). |
The issue may well be that the version of Telnet++ in vcpkg has not been updated in 7 months. |
@KazDragon can you push an update ? |
I think Telnet++ is failed with dynamic linking in Visual Studio. |
I've just integrated a change that enables Telnet++ to be built as a dll on Visual Studio 2019. Does this solve your problem? |
@KazDragon Thank you for support.
|
Yeah, I've been researching C4251 and it looks like this is a warning that unless you explicitly export some things, then runtime-linking the DLL with an executable built with a different version of the compiler/library will fail. All things being equal, I think that's safe to ignore. I'm working on a changeset that removes these warnings. But I see only warnings and no error, so it worked? See: #240 |
Oh I see it's still there:
|
Now that I've cleared out all the noise and purged any remaining traces of Boost from my vcpkg installation (which is way more difficult than it should be), I've finally managed to reproduce the error. I have a simple workaround that makes it work again. I'll commit that and then we can move on and I will work on working around my workaround ;) |
@yurybura Would you be able to build with the PR branch and verify that is resolves the error? |
Fix for this is on master, though I'm reopening to give @yurybura the opportunity to tell me whether it worked or not ;) |
@KazDragon I can confirm that my local build is passed. |
🎆 Thanks, @yurybura! |
telnetpp
doesn't compile with MSVC compiler and Boost 1.75.0.Error:
More information you can find in PR: microsoft/vcpkg#15090
Full build log: https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_apis/build/builds/46451/artifacts?artifactName=failure%20logs%20for%20x64-windows&api-version=6.0&%24format=zip
The text was updated successfully, but these errors were encountered: