Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[assimp] Fix cmake config name and add cmake version #14554

Merged
merged 2 commits into from
Nov 16, 2020
Merged

[assimp] Fix cmake config name and add cmake version #14554

merged 2 commits into from
Nov 16, 2020

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Nov 13, 2020 •
edited
Loading

Fixes #14256 and #14255

  1. Fix assimp cmake config name from AssimpConfig.cmake to assimpConfig.cmake
  2. Export assimpConfigVersion.cmake file.

Currently the usage is:

The package assimp:x64-windows provides CMake targets:

    find_package(assimp CONFIG REQUIRED)
    target_link_libraries(main PRIVATE assimp::assimp)

assimp doesn't contains any features.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 13, 2020
@PhoebeHui PhoebeHui changed the title [assimp] Fix cmake cofig name and add cmake version [assimp] Fix cmake config name and add cmake version Nov 13, 2020
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 16, 2020
@strega-nil strega-nil merged commit 0b4db02 into microsoft:master Nov 16, 2020
@strega-nil
Copy link
Contributor

Thanks phoebe :)

@traversaro
Copy link
Contributor

Thanks a lot @PhoebeHui !

@PhoebeHui PhoebeHui deleted the dev/Phoebe/assimp branch November 23, 2020 07:20
seanyen pushed a commit to ms-iot/vcpkg that referenced this pull request Mar 12, 2021
@PhoebeHui @seanyen
[assimp] Fix cmake config name and add cmake version (microsoft#14554)
24b36a0 
* [assimp] Fix cmake cofig name and add cmake version

* [ogre] Update 'Assimp' to 'assimp
ResearchDaniel added a commit to inviwo/inviwo that referenced this pull request Apr 8, 2022
@ResearchDaniel
Assimp: Fix for assimp cmake config not found.
b2d7428 
microsoft/vcpkg#14554
Packaging: Remove compressed files when packaging installer to save space for CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@strega-nil strega-nil strega-nil approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[assimp] assimp CMake package name is Assimp, not consitent with other platforms where it is assimp
4 participants
@PhoebeHui @strega-nil @traversaro @JackBoosY