-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[assimp] assimp CMake package name is Assimp, not consitent with other platforms where it is assimp #14256
Comments
@traversaro, the official config name update to assimpConfig.cmake, so we may not change it to assimp-config.cmake See https://github.com/assimp/assimp/blob/master/CMakeLists.txt#L406. |
I know, I was the one adding that line (see assimp/assimp#3455). : ) Both
The problem is that instead vcpkg is suggesting to use
So, brief recap:
|
I will summit a PR to fix this, thanks for bringing this up! |
Describe the bug
The assimp vcpkg port install a CMake config file called
AssimpConfig.cmake
, that is not consistent with theassimp-config.cmake
installed by other package managers such as homebrew or apt.Environment
To Reproduce
Steps to reproduce the behavior:
share/assimp
you can find theAssimpConfig.cmake
file, differently from apt and homebrew that install anassimp-config.cmake
file (see for example https://packages.debian.org/sid/amd64/libassimp-dev/filelist)Expected behavior
I would expect the vcpkg port to install a
assimp-config.cmake
file as well.Failure logs
-(please attached failure logs)
Additional context
assimp CMake config files have been historically very problematic. PR #13264 solve most of the problems, but introduced this regression.
The text was updated successfully, but these errors were encountered: