-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[assimp] Fix generated -config files to use more generic form #13264
Conversation
How does this compare to #12437 ? |
OK, this is fine to me but please sync with @JackBoosY on the other review. |
The failures on x64-linux due to this:
|
Assimps own hardcoded config files uses the target name "assimp::assimp" but with this change the name will be "Assimp::assimp" which breaks compatibility... |
I've added in a backwards-compatible alias that forwards This PR should now handle all cases covered in #12437. @JackBoosY Are there any remaining uncovered issues as far as you can tell? |
In #12199 I had to modify assimp a lot, involving some of the things here |
Will test usage on Linux. |
Passed. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
May I ask you a comment about the fixes in #12199? IMHO those are very different and maybe more complete. These fixes here do not solve almost anything related to the problems I had there in using assimp |
Also another comment about the note in the portfile: irrlicht contains irrxml, but technically that port should use “external” irrxml (which I added and worked in the above PR) |
hmmm this also broke #13464. So why is irrxml embedded and not an extra port? |
Assimp has two sets of config files: one that properly handles dependencies and one that doesn't. This PR switches which set to install.
Additionally, this PR causes the embedded IrrXML source to be built directly into the assimp library instead of as a separate binary for simpler consumption.
Fixes [assimp] static link failure #13253 assimp build failure #12154 assimp package does not link irrXML #9918 assimp build failure using CMake #9022