[boost] Update to 1.74.0 #14089

niclar · 2020-10-16T13:19:33Z

Update to boost-1.74.0

Fixes issue #13033

Tested
x64-windows-static
x64-linux-static

…ame prefix

…e13033

ghost · 2020-10-16T13:19:48Z

All CLA requirements met.

PhoebeHui · 2020-10-19T07:15:04Z

Thank you @niclar and all for your effort!

Here is CI testing failures, let me know if you need full failure logs.

gamedev-framework:x64-windows-static/gamedev-framework:x64-windows/gamedev-framework:x86-windows:

Failures:

D:\installed\x64-windows\include\boost/heap/detail/heap_node.hpp(145): error C2300: 'boost::heap::detail::parent_pointing_heap_node<gf::v1::`anonymous-namespace'::AStarHeapData>': class does not have a destructor called '~Node'

bond:arm64-windows/bond:x86-windows:

Failures:

D:\buildtrees\bond\src\9.0.2-8585f9f7d7.clean\cpp\inc\bond/core/exception.h(12): fatal error C1083: Cannot open include file: 'boost/locale/encoding_utf.hpp': No such file or directory

boost-nowide:x64-osx:

Failures:

clang-darwin.compile.c++ /Volumes/data/buildtrees/boost-nowide/x64-osx-dbg/boost/build/e09119a5fb93bc4a6ae7c27175ce30d3/filebuf.o
../src/filebuf.cpp:46:9: error: unknown type name 'constexpr'
        constexpr bool is_in_range(U value)
        ^
../src/filebuf.cpp:62:19: warning: 'auto' type specifier is a C++11 extension [-Wc++11-extensions]
            const auto pos = BOOST_NOWIDE_FTELL(file);
                  ^
../src/filebuf.cpp:74:17: error: no matching function for call to 'is_in_range'
            if(!is_in_range<BOOST_NOWIDE_OFF_T>(offset))
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/filebuf.cpp:57:20: error: no matching function for call to 'is_in_range'
            return is_in_range<T>(value) ? static_cast<T>(value) : T(-1);
                   ^~~~~~~~~~~~~~
../src/filebuf.cpp:67:20: note: in instantiation of function template specialization 'boost::nowide::detail::cast_if_valid_or_minus_one<long long, long long>' requested here
            return cast_if_valid_or_minus_one<std::streamoff>(pos);
                   ^
1 warning and 3 errors generated.

PhoebeHui

Could you remove the Port-Version in affect CONTROL files?

ports/boost-build/CONTROL

ports/boost-context/CONTROL

ports/boost-coroutine/CONTROL

ports/boost-fiber/CONTROL

ports/boost-filesystem/CONTROL

ports/boost-python/CONTROL

ports/boost-stacktrace/CONTROL

ports/boost-test/CONTROL

ports/boost-wave/CONTROL

ports/boost/CONTROL

scripts/boost/post-source-stubs/nowide.cmake

niclar · 2020-10-19T14:26:37Z

@Victor-Bergman can you take a look at ports\0001-Fix-boost-ICU-support.patch & ports\boost-locale\0001-Fix-boost-ICU-support.patch, seems like it prevents x86 deployment of locale

niclar · 2020-10-20T08:43:10Z

-can someone with a osx box take a look at the build ?

niclar · 2020-10-20T08:45:22Z

@jube & @ahugeat can you provide a boost 1.74 patch to gamedev-framework ?

ahugeat · 2020-10-20T19:26:39Z

Hello @niclar,

I have cloned your repo and the compilation of x64-windows is working.
Since we have recently updated gamedev-framework, I have tried with the new version. The triplets x64-windows, x86-windows, x64-windows-static and x86-windows-static are working.

Could you try again to compile the gamedev-framework and if it fails, could you send us the complete logs?

PhoebeHui · 2020-10-28T08:38:49Z

Sorry for my late reply.

The failures on CI testing:

gamedev-framework:x64-windows and gamedev-framework:x86-windows:

D:\installed\x64-windows\include\boost/heap/detail/heap_node.hpp(145): error C2300: 'boost::heap::detail::parent_pointing_heap_node<gf::v1::`anonymous-namespace'::AStarHeapData>': class does not have a destructor called '~Node'

gamedev-framework.zip

bond:x86-windows and bond:arm64-windows:

D:\buildtrees\bond\src\9.0.2-8585f9f7d7.clean\cpp\inc\bond/core/exception.h(12): fatal error C1083: Cannot open include file: 'boost/locale/encoding_utf.hpp': No such file or directory

bond.zip

x64-linux and x64-osx:
boost-atomic
boost-container
boost-exception
boost-regex
boost-signals
boost-stacktrace
boost-system

The above port failed with same error:

CMake Error at CMakeLists.txt:117:
  Parse error.  Function missing ending ")".  End of file reached.

longnguyen2004 · 2020-10-28T17:37:36Z

@niclar Seems like you forget a closing paren :)
I'll try to find some time to test gamedev with MSVC and llvm-mingw later

victorburckel · 2020-10-31T17:39:49Z

Hi, don't know if this can help, but it does not seem to be a bug related to the gamedev port. Rather it seems to be a bug with msvc compiling boost binomial heap 1.74. I reported it to see wether it is a bug or not (https://developercommunity.visualstudio.com/content/problem/1240121/problem-compiling-boost-binomial-heap.html). Meanwhile it seems it can be bypassed by patching the following line: https://github.com/boostorg/heap/blob/c0a8773051cd8bc0691ea3c067d59b4d4c5e96dc/include/boost/heap/detail/heap_node.hpp#L145 with a function call [](Node* n){ n->~Node(); }(n);

victorburckel · 2020-11-02T09:05:18Z

Hello @niclar,

I tried to implement some fixes in #14337, the checks now run ok, can you check if this is ok for you, and maybe integrate them ?

Thanks

longnguyen2004 · 2020-11-03T04:38:38Z

If there are no updates from niclar in the coming days then we might as well merge #14337 instead
@victorburckel Can you try opening a PR on niclar's branch?

victorburckel · 2020-11-03T09:54:59Z

Hi, @longnguyen2004 I'm not able to do a pull request on his repository.

niclar · 2020-11-03T19:56:36Z

@victorburckel , great! -I'll take a look tomorrow..

victorburckel · 2020-11-04T07:28:29Z

@niclar Ok thanks, I took the liberty to push the commits to your repo so that we have the status (should be the same, hope you don't mind).
You'll see there's not much:

a patch for boost heap which comes directely from boost develop branch

the compilation of boost nowide with std=c++11 for apple (the CXXFLAGS in your fcbee3a commit are not taken into account as apple compilation uses clang and there is no such configuration for apple which forwards these flags as for gcc

vcpkg/ports/boost-modular-build-helper/user-config.jam

Lines 13 to 22 in 00d190a

    
           using gcc : 5.4.1 : @CMAKE_CXX_COMPILER@
 
               :
 
               <ranlib>@CMAKE_RANLIB@
 
               <archiver>@CMAKE_AR@
 
               @CXXFLAGS@
 
               @CFLAGS@
 
               @LDFLAGS@
 
               # MINGW here causes b2 to not run cygpath
 
               <flavor>mingw
 
               ;

)

a new dependency to boost locale for the bond port

longnguyen2004 · 2020-11-04T07:33:29Z

@victorburckel @niclar Please also backport this commit, which fixes a bug when building with llvm-mingw

victorburckel · 2020-11-04T08:23:12Z

@longnguyen2004 Sure, done

…e13033

niclar · 2020-11-04T10:14:47Z

@victorburckel, it looks good now, thanks. Let's await the test suite run..

victorburckel · 2020-11-04T13:38:36Z

Now there's a link error in rtabmap, but I see the exact same error in other PR, so there are chances the regression does not come from this PR
Here's a sample of the error:

octomap.lib(OcTreeNode.cpp.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in Rtabmap.cpp.obj

niclar · 2020-11-04T14:46:32Z

@seanyen, rtabmap debug seem to link to the octomap release library (for x86-windows & x64-windows debug builds), -can you take a look ?

victorburckel · 2020-11-04T17:53:54Z

That's strange, in the output of x64_windows I don't see any errors. I tried to reproduce the error on my machine for the x86 build, but I don't get any error.

niclar · 2020-11-04T18:29:27Z

@victorburckel if you install the octomap lib first (which is apparently done on the CI machine) rtabmap will optionally use it & you'll be able to reproduce the issue

niclar · 2020-11-04T18:33:10Z

@ras0219-msft et al. I can't understand why master is allowed to fail (or isn't staged) .. so I'll jump out of this rabbit hole until it passes.

PhoebeHui · 2020-11-05T02:07:51Z

I will take a look at the rtabmap failure in CI testing, please ignore it.

victorburckel · 2020-11-05T08:51:32Z

Nice, thanks a lot

niclar · 2020-11-05T08:57:02Z

@PhoebeHui thanks

PhoebeHui · 2020-11-06T09:19:46Z

Feature 'icu' has been tested for boost-locale and boost-regex, all passed with x64-windows.

One new components 'boost-stl-interfaces' was added in this revision.

@ras0219-msft, @BillyONeal, could you help further review?

BillyONeal · 2020-11-06T21:30:26Z

Thanks for your (clearly extensive) help here! 👍

SeanFarrow and others added 9 commits October 12, 2020 03:41

Remove the Beast coroutine patch as it has now been integrated upstream.

6bd10af

Update the boost version to 1.74.

551bb17

made boost 1.74 nowide & outcome build

f783672

updated boost build helper with version 1.74.0

fc08af1

use boost build 1.74

f870b52

update boost-build and boost-uninstall to 1.74

8dd067d

correct boost 1.74 build SHA512

6fdcb2e

[boost modular build] added the v142 toolset & fixed boost 1.74 filen…

512a349

…ame prefix

Merge branch 'master' of https://github.com/microsoft/vcpkg into Issu…

d249aed

…e13033

LilyWangL assigned PhoebeHui Oct 19, 2020

PhoebeHui changed the title ~~Issue13033~~ [boost] Update to 1.74.0 Oct 19, 2020

PhoebeHui added the requires:author-response label Oct 19, 2020

PhoebeHui mentioned this pull request Oct 19, 2020

Update Boost to v1.74. #14106

Closed

PhoebeHui requested changes Oct 19, 2020

View reviewed changes

scripts/boost/post-source-stubs/nowide.cmake Show resolved Hide resolved

PhoebeHui requested a review from ras0219-msft October 19, 2020 10:16

[boost 1.74] removed Port-Version

5c28eb3

[boost 1.74] set -std=c++11 & libc++ for apple clang

fcbee3a

compile boost-nowide with std=c++11

fcefe90

Backport fix for llvm-mingw build

42278e0

Merge branch 'master' of https://github.com/microsoft/vcpkg into Issu…

03ebd23

…e13033

PhoebeHui mentioned this pull request Nov 5, 2020

[vcpkg baseline] [rtabmap] Set option dependencies OFF #14400

Merged

Merge remote-tracking branch 'upstream/master' into Issue13033

9fc7622

PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 6, 2020

PhoebeHui requested a review from BillyONeal November 6, 2020 09:33

BillyONeal merged commit 0e12523 into microsoft:master Nov 6, 2020

yurybura mentioned this pull request Sep 22, 2021

fix mpl emergency #10614

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[boost] Update to 1.74.0 #14089

[boost] Update to 1.74.0 #14089

niclar commented Oct 16, 2020

ghost commented Oct 16, 2020 •

edited by ghost

Loading

PhoebeHui commented Oct 19, 2020

PhoebeHui left a comment

niclar commented Oct 19, 2020

niclar commented Oct 20, 2020

niclar commented Oct 20, 2020

ahugeat commented Oct 20, 2020

PhoebeHui commented Oct 28, 2020

longnguyen2004 commented Oct 28, 2020

victorburckel commented Oct 31, 2020

victorburckel commented Nov 2, 2020

longnguyen2004 commented Nov 3, 2020 •

edited

Loading

victorburckel commented Nov 3, 2020

niclar commented Nov 3, 2020

victorburckel commented Nov 4, 2020

longnguyen2004 commented Nov 4, 2020

victorburckel commented Nov 4, 2020

niclar commented Nov 4, 2020

victorburckel commented Nov 4, 2020

niclar commented Nov 4, 2020 •

edited

Loading

victorburckel commented Nov 4, 2020

niclar commented Nov 4, 2020

niclar commented Nov 4, 2020 •

edited

Loading

PhoebeHui commented Nov 5, 2020

victorburckel commented Nov 5, 2020

niclar commented Nov 5, 2020

PhoebeHui commented Nov 6, 2020 •

edited

Loading

BillyONeal commented Nov 6, 2020

[boost] Update to 1.74.0 #14089

[boost] Update to 1.74.0 #14089

Conversation

niclar commented Oct 16, 2020

ghost commented Oct 16, 2020 • edited by ghost Loading

PhoebeHui commented Oct 19, 2020

PhoebeHui left a comment

Choose a reason for hiding this comment

niclar commented Oct 19, 2020

niclar commented Oct 20, 2020

niclar commented Oct 20, 2020

ahugeat commented Oct 20, 2020

PhoebeHui commented Oct 28, 2020

longnguyen2004 commented Oct 28, 2020

victorburckel commented Oct 31, 2020

victorburckel commented Nov 2, 2020

longnguyen2004 commented Nov 3, 2020 • edited Loading

victorburckel commented Nov 3, 2020

niclar commented Nov 3, 2020

victorburckel commented Nov 4, 2020

longnguyen2004 commented Nov 4, 2020

victorburckel commented Nov 4, 2020

niclar commented Nov 4, 2020

victorburckel commented Nov 4, 2020

niclar commented Nov 4, 2020 • edited Loading

victorburckel commented Nov 4, 2020

niclar commented Nov 4, 2020

niclar commented Nov 4, 2020 • edited Loading

PhoebeHui commented Nov 5, 2020

victorburckel commented Nov 5, 2020

niclar commented Nov 5, 2020

PhoebeHui commented Nov 6, 2020 • edited Loading

BillyONeal commented Nov 6, 2020

ghost commented Oct 16, 2020 •

edited by ghost

Loading

longnguyen2004 commented Nov 3, 2020 •

edited

Loading

niclar commented Nov 4, 2020 •

edited

Loading

niclar commented Nov 4, 2020 •

edited

Loading

PhoebeHui commented Nov 6, 2020 •

edited

Loading