-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost] Update to 1.74.0 #13033
Comments
If there were instructions on how to do this, I'm happy to help as it's something a project I'm working on needs to fully move to VCPKG as a packange manager. |
It has something to do with this PowerShell script I think |
Ah… OK…, let me have a look at that and see what I can come up with!
Thanks,
Sean.
From: Long Nguyen <[email protected]>
Sent: 25 August 2020 14:50
To: microsoft/vcpkg <[email protected]>
Cc: Sean Farrow <[email protected]>; Comment <[email protected]>
Subject: Re: [microsoft/vcpkg] [boost] Update to 1.74.0 (#13033)
It has something to do with this PowerShell script<https://github.com/microsoft/vcpkg/blob/master/scripts/boost/generate-ports.ps1> I think
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#13033 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7QFW5DOEKLDWYILAG3SCO6RBANCNFSM4QGLJGLA>.
|
Ok, if you change all the references from 1.73 to 1.74 in the script you reference, change the PowerShell execution policy to unrestricted for the current session and have VCPKG somewhere on the path, you should be able to run the script and update the port locally.
There is a new header-only library with 1.74, Nowide, so I’m not sure how new libraries are handled as we might want a new installable package for that.
From: Long Nguyen <[email protected]>
Sent: 25 August 2020 14:50
To: microsoft/vcpkg <[email protected]>
Cc: Sean Farrow <[email protected]>; Comment <[email protected]>
Subject: Re: [microsoft/vcpkg] [boost] Update to 1.74.0 (#13033)
It has something to do with this PowerShell script<https://github.com/microsoft/vcpkg/blob/master/scripts/boost/generate-ports.ps1> I think
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#13033 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7QFW5DOEKLDWYILAG3SCO6RBANCNFSM4QGLJGLA>.
|
It should be automatically handled by this line |
Ok, can you try just changing the version references from 1.73 to 1.74 and let me know how that goes.
I can’t check this myself before the weekend unfortunately.
Thanks,
Sean.
From: Long Nguyen <[email protected]>
Sent: 25 August 2020 15:52
To: microsoft/vcpkg <[email protected]>
Cc: Sean Farrow <[email protected]>; Comment <[email protected]>
Subject: Re: [microsoft/vcpkg] [boost] Update to 1.74.0 (#13033)
It should be automatically handled by this line<https://github.com/microsoft/vcpkg/blob/master/scripts/boost/generate-ports.ps1#L230>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#13033 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7TXDW3IYYA6V46EF4TSCPF23ANCNFSM4QGLJGLA>.
|
Alright I'll test it tomorrow |
OK, I've now started some work on this on a private branch. |
Can anyone works on this? I'm quite busy now |
I think I know what the fix is, give me the weekend to validate my thinking.
From: Long Nguyen <[email protected]>
Sent: 09 September 2020 08:09
To: microsoft/vcpkg <[email protected]>
Cc: Sean Farrow <[email protected]>; Comment <[email protected]>
Subject: Re: [microsoft/vcpkg] [boost] Update to 1.74.0 (#13033)
Can anyone works on this? I'm quite busy now
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#13033 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7XU5LU2BLIW2VALNM3SE4SYLANCNFSM4QGLJGLA>.
|
I see boost/STLInterfaces has been added in the 1.74 update, https://www.boost.org/users/history/version_1_74_0.html |
I'll try to get some time to work on this tonight |
OK, I’ve forked and finished 90 % of the work, so If you want to carry on, go to:
https://github.com/SeanFarrow/vcpkg.git
The branch you want is Issue13033.
The only issue I can see remaining is the completion of correctly building the nowide library, they changed the way this works in 1.74 and used config checks.
Thanks,
Sean.
From: Long Nguyen <[email protected]>
Sent: 22 September 2020 02:41
To: microsoft/vcpkg <[email protected]>
Cc: Sean Farrow <[email protected]>; Comment <[email protected]>
Subject: Re: [microsoft/vcpkg] [boost] Update to 1.74.0 (#13033)
I'll try to get some time to work on this tonight
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#13033 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7USRSAPWJU7KUWKYNDSG76BFANCNFSM4QGLJGLA>.
|
-@SeanFarrow, can't see the Issue13033 branch... |
Give me until tomorrow, I forgot to push!
From: niclar <[email protected]>
Sent: 12 October 2020 15:06
To: microsoft/vcpkg <[email protected]>
Cc: Sean Farrow <[email protected]>; Mention <[email protected]>
Subject: Re: [microsoft/vcpkg] [boost] Update to 1.74.0 (#13033)
-@SeanFarrow<https://github.com/SeanFarrow>, can't see the Issue13033 branch...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#13033 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7ST6RYXAHXJU5JGRD3SKMEM5ANCNFSM4QGLJGLA>.
|
@niclar, Then, this library fails to build, I'm assuming because it fails to find some targets in the .bjam file. |
@SeanFarrow & @longnguyen2004 , alright I forked it and boost 1.74 now builds in my branch... -I'm totally new to vcpkg. But to my understanding the below is at least remaining before a PR; update ports\boost-modular-build-helper\CONTROL and ports\boost-modular-build-helper\Jamroot.jam with the new version (I'm unsure if that's sufficient for that module, maybe someone more proficient in vcpkg & the vcpkg boost build can guide me). validate the old/remaining boost patches |
@niclar Are you able to submit a PR to my original branch, I'll then take things from there. |
sure, SeanFarrow#1 |
I don't really know much about the way vcpkg handles boost, so @SeanFarrow and @niclar please finish it for me, and I'll work on the mingw part. |
No worries, you'll have a PR by the end of the week |
works now for linux & windows (including the latest toolset) in: https://github.com/niclar/vcpkg/tree/Issue13033 |
@niclar if you can create a pull request to my fork, I'll fix this this weekend and we can get it merged upstream as soon as practically possible. |
@longnguyen2004 Did you manage to have a look at the pull request created by @niclar? |
I'll try to find some free time to test it with llvm-mingw. |
Fantastic, it’s working fine with Visual Studio 2019.
From: Long Nguyen <[email protected]>
Sent: 27 October 2020 10:33
To: microsoft/vcpkg <[email protected]>
Cc: Sean Farrow <[email protected]>; Mention <[email protected]>
Subject: Re: [microsoft/vcpkg] [boost] Update to 1.74.0 (#13033)
I'll try to find some free time to test it with llvm-mingw.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#13033 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7XQIFI2LL2MI2ALRDDSM2OVLANCNFSM4QGLJGLA>.
|
Seems to work fine with llvm-mingw as well! |
Are you happy to merge this?
As an FYI, when boost 1.75 is released (scheduled for around the 2nd December), I’ll create an issue/patch.
Thanks,
Sean.
From: Long Nguyen <[email protected]>
Sent: 28 October 2020 08:38
To: microsoft/vcpkg <[email protected]>
Cc: Sean Farrow <[email protected]>; Mention <[email protected]>
Subject: Re: [microsoft/vcpkg] [boost] Update to 1.74.0 (#13033)
Seems to work fine with llvm-mingw as well!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#13033 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALDK7W2WONQXXS5OCAQUB3SM7J4XANCNFSM4QGLJGLA>.
|
@niclar How's the PR going? It looks pretty good to me |
Alright we can close this now :) Thanks everyone for their help |
Library name: boost
New version number: 1.74.0
Other information that may be useful (release notes, etc...)
There are some mingw related fixes in boost-build that I'd like to have
The text was updated successfully, but these errors were encountered: