Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] Update to 1.74.0 #13033

Closed
longnguyen2004 opened this issue Aug 20, 2020 · 30 comments
Closed

[boost] Update to 1.74.0 #13033

longnguyen2004 opened this issue Aug 20, 2020 · 30 comments
Assignees
Labels
category:port-update The issue is with a library, which is requesting update new revision

Comments

@longnguyen2004
Copy link
Contributor

Library name: boost

New version number: 1.74.0

Other information that may be useful (release notes, etc...)
There are some mingw related fixes in boost-build that I'd like to have

@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Aug 21, 2020
@SeanFarrow
Copy link

If there were instructions on how to do this, I'm happy to help as it's something a project I'm working on needs to fully move to VCPKG as a packange manager.

@longnguyen2004
Copy link
Contributor Author

It has something to do with this PowerShell script I think

@SeanFarrow
Copy link

SeanFarrow commented Aug 25, 2020 via email

@SeanFarrow
Copy link

SeanFarrow commented Aug 25, 2020 via email

@longnguyen2004
Copy link
Contributor Author

It should be automatically handled by this line

@SeanFarrow
Copy link

SeanFarrow commented Aug 25, 2020 via email

@longnguyen2004
Copy link
Contributor Author

Alright I'll test it tomorrow

@SeanFarrow
Copy link

OK, I've now started some work on this on a private branch.
I'm struggling to get Nowide building as the jam.v2 file has changed and is now looking for config, which it searches for in the wrong directory.
I'm thinking of adding a cmake file to handle this and update where it thinks the config file is, or should we crate a patch, if so what againsh?

@longnguyen2004
Copy link
Contributor Author

Can anyone works on this? I'm quite busy now

@SeanFarrow
Copy link

SeanFarrow commented Sep 9, 2020 via email

@StarGate-One
Copy link
Contributor

I see boost/STLInterfaces has been added in the 1.74 update, https://www.boost.org/users/history/version_1_74_0.html

@longnguyen2004
Copy link
Contributor Author

I'll try to get some time to work on this tonight

@SeanFarrow
Copy link

SeanFarrow commented Sep 22, 2020 via email

@niclar
Copy link
Contributor

niclar commented Oct 12, 2020

-@SeanFarrow, can't see the Issue13033 branch...

@SeanFarrow
Copy link

SeanFarrow commented Oct 12, 2020 via email

@SeanFarrow
Copy link

@niclar,
This has now been pushed, the branch you want from my fork is Issue13033.
I've updated the version in scripts/boost/generate-ports.ps1, but when I try to do:
vcpkg install boost-nowide:x86-windows-static
There is an issue around finding the config folder (we need a cmake file to copy this in.)

Then, this library fails to build, I'm assuming because it fails to find some targets in the .bjam file.
Once these two issues have been fixed, we can do some testing and then should be good to go!
Thanks,
Sean.

@niclar
Copy link
Contributor

niclar commented Oct 13, 2020

@SeanFarrow & @longnguyen2004 , alright I forked it and boost 1.74 now builds in my branch...

niclar@f783672

-I'm totally new to vcpkg. But to my understanding the below is at least remaining before a PR;

update ports\boost-modular-build-helper\CONTROL and ports\boost-modular-build-helper\Jamroot.jam with the new version (I'm unsure if that's sufficient for that module, maybe someone more proficient in vcpkg & the vcpkg boost build can guide me).

validate the old/remaining boost patches

@SeanFarrow
Copy link

@niclar Are you able to submit a PR to my original branch, I'll then take things from there.

@niclar
Copy link
Contributor

niclar commented Oct 13, 2020

sure, SeanFarrow#1

@longnguyen2004
Copy link
Contributor Author

I don't really know much about the way vcpkg handles boost, so @SeanFarrow and @niclar please finish it for me, and I'll work on the mingw part.

@SeanFarrow
Copy link

No worries, you'll have a PR by the end of the week

@niclar
Copy link
Contributor

niclar commented Oct 14, 2020

works now for linux & windows (including the latest toolset) in: https://github.com/niclar/vcpkg/tree/Issue13033

@SeanFarrow
Copy link

@niclar if you can create a pull request to my fork, I'll fix this this weekend and we can get it merged upstream as soon as practically possible.

@SeanFarrow
Copy link

@longnguyen2004 Did you manage to have a look at the pull request created by @niclar?

@longnguyen2004
Copy link
Contributor Author

I'll try to find some free time to test it with llvm-mingw.

@SeanFarrow
Copy link

SeanFarrow commented Oct 27, 2020 via email

@longnguyen2004
Copy link
Contributor Author

Seems to work fine with llvm-mingw as well!

@SeanFarrow
Copy link

SeanFarrow commented Oct 28, 2020 via email

@longnguyen2004
Copy link
Contributor Author

@niclar How's the PR going? It looks pretty good to me

This was referenced Nov 1, 2020
@longnguyen2004
Copy link
Contributor Author

longnguyen2004 commented Nov 7, 2020

Alright we can close this now :) Thanks everyone for their help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
5 participants