-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Added python script to generate all packages file list, added to azur… #12177
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
548401b
Added python script to generate all packages file list, added to azur…
123300e
fixed an issue that causes some leading slashes were being removed
c17c785
Header Database now includes hpp files for C++ header files
a4f8ba3
Changed Header Database to include all files under \include\ folder
3acf307
Apply suggestions from code review, changing condition from eq to ne
8d8b1f0
Update last condition from eq to ne
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
import os | ||
import os.path | ||
import sys | ||
|
||
|
||
keyword = "include/" | ||
|
||
def getFiles(path): | ||
files = os.listdir(path) | ||
return list(filter(lambda x: x[0] != '.', files)) | ||
|
||
def gen_all_file_strings(path, files, headers, output): | ||
for file in files: | ||
package = file[:file.find("_")] | ||
f = open(path + file) | ||
for line in f: | ||
idx = line.strip().find(keyword) | ||
if idx >= 0 and line.strip()[-1] != "/": | ||
headers.write(package + ":" + line[idx + len(keyword):]) | ||
output.write(package + ":" + line[idx-1:]) | ||
elif line.strip()[-1] != "/": | ||
output.write(package + ":" + line[line.find("/"):]) | ||
f.close() | ||
|
||
def main(path): | ||
try: | ||
os.mkdir("scripts/list_files") | ||
except FileExistsError: | ||
print("Path already exists, continuing...") | ||
|
||
headers = open("scripts/list_files/VCPKGHeadersDatabase.txt", mode='w') | ||
output = open("scripts/list_files/VCPKGDatabase.txt", mode='w') | ||
gen_all_file_strings(path, getFiles(path), headers, output) | ||
headers.close() | ||
output.close() | ||
|
||
if __name__ == "__main__": | ||
main(sys.argv[1]) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to cause a merge conflict with a @ras0219 PR which removes this explicit variable set.
Also, why duplicate the fetch python3 call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second fetch python3 call was to get the executable file path to execute python.
Which variable set does the PR remove exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#12198 <- This is the conflicting change. Your PR landed first so the comment goes to that one instead.