-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] Added python script to generate all packages file list, added to azur… #12177
Conversation
…e pipeline to build at the end of the run
It looks like some leading slashes are being removed: From the x86-windows VCPKGDatabase.txt:
|
It would be best to include all files starting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the conditions are flipped :)
Co-authored-by: Billy O'Neal <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
$env:VCPKG_DOWNLOADS = "D:\downloads" | ||
./vcpkg.exe fetch python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to cause a merge conflict with a @ras0219 PR which removes this explicit variable set.
Also, why duplicate the fetch python3 call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second fetch python3 call was to get the executable file path to execute python.
Which variable set does the PR remove exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#12198 <- This is the conflicting change. Your PR landed first so the comment goes to that one instead.
LGTM, thanks Leo @yaoleo34 ! |
A Python script is added in order to generate a full list of header files, called VCPKGHeaderDatabase.txt, this file is to be used for VS Code. A separate file is generated for all packages file list, called VCPKGDatabase.txt, this file is to be used for vcpkg website. This is achieved through Azure pipelines to generate these file lists at the end of the build.