display progress counters at fixed locations #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Apr 13, 2022
include/vcpkg/remove.h
Outdated
| DECLARE_MESSAGE(RemovingPackage, | ||
| (msg::action_index, msg::action_count, msg::spec), | ||
| "", | ||
| "Removing {action_index}/{action_count} {spec}"); |
There was a problem hiding this comment.
Suggested change
| "Removing {action_index}/{action_count} {spec}"); | |
| "[{action_index}/{action_count}] Removing {spec}"); |
I think this was dg0yt's suggestion? (same for other examples)
I don't have strong opinions here I just want to make sure you considered this.
There was a problem hiding this comment.
Imo [x/y] looks only good when every line is prefixed with [x/y]
BillyONeal
approved these changes
Apr 13, 2022
vicroms
approved these changes
Apr 13, 2022
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437 (comment)
cc @dg0yt