Implement published test results built in and reduce console chattiness. #437

BillyONeal · 2022-03-16T03:26:08Z

Built in implementation of microsoft/vcpkg#23477

Before:

PS C:\Dev\vcpkg> .\vcpkg.exe install zlib
Computing installation plan...
The following packages will be built and installed:
    zlib[core]:x86-windows -> 1.2.11#13
Detecting compiler hash for triplet x86-windows...
Restored 1 packages from C:\Users\bion\AppData\Local\vcpkg\archives in 43.57 ms. Use --debug to see more details.
Starting package 1/1: zlib:x86-windows
Installing package zlib[core]:x86-windows...
Elapsed time for package zlib:x86-windows: 18.41 ms

Total elapsed time: 2.266 s

The package zlib is compatible with built-in CMake targets:

    find_package(ZLIB REQUIRED)
    target_link_libraries(main PRIVATE ZLIB::ZLIB)

PS C:\Dev\vcpkg> .\vcpkg.exe remove zlib
The following packages will be removed:
    zlib:x86-windows
Removing package zlib:x86-windows...
PS C:\Dev\vcpkg> .\vcpkg.exe install zlib --no-binarycaching
Computing installation plan...
The following packages will be built and installed:
    zlib[core]:x86-windows -> 1.2.11#13
Detecting compiler hash for triplet x86-windows...
Starting package 1/1: zlib:x86-windows
Building package zlib[core]:x86-windows...
-- Using cached zlib1211.tar.gz.
-- Extracting source C:/Dev/vcpkg-downloads/zlib1211.tar.gz
-- Applying patch cmake_dont_build_more_than_needed.patch
-- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch
-- Applying patch add_debug_postfix_on_mingw.patch
-- Applying patch 0002-android-build-mingw.patch
-- Using source at C:/Dev/vcpkg/buildtrees/zlib/src/1.2.11-e9a093319e.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/vcpkg-cmake-wrapper.cmake
-- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/lib/pkgconfig/zlib.pc
-- Using cached msys-mingw-w64-i686-pkg-config-0.29.2-3-any.pkg.tar.zst.
-- Using cached msys-mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst.
-- Using msys root at C:/Dev/vcpkg-downloads/tools/msys2/9a1ec3f33446b195
-- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/debug/lib/pkgconfig/zlib.pc
-- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/copyright
-- Performing post-build validation
-- Performing post-build validation done
Installing package zlib[core]:x86-windows...
Elapsed time for package zlib:x86-windows: 4.83 s

Total elapsed time: 7.009 s

The package zlib is compatible with built-in CMake targets:

    find_package(ZLIB REQUIRED)
    target_link_libraries(main PRIVATE ZLIB::ZLIB)

PS C:\Dev\vcpkg> .\vcpkg.exe x-set-installed
The following packages will be removed:
    zlib:x86-windows
Starting package 1/1: zlib:x86-windows
Removing package zlib:x86-windows...
Elapsed time for package zlib:x86-windows: 9.93 ms
Restored 0 packages from C:\Users\bion\AppData\Local\vcpkg\archives in 92.5 us. Use --debug to see more details.

Total elapsed time: 14.01 ms

PS C:\Dev\vcpkg> .\vcpkg.exe remove zlib
The following packages are not installed, so not removed:
    zlib:x86-windows
Package zlib:x86-windows is not installed
PS C:\Dev\vcpkg>

After:

PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe install zlib
Computing installation plan...
The following packages will be built and installed:
    zlib[core]:x86-windows -> 1.2.11#13
Detecting compiler hash for triplet x86-windows...
Restored 1 packages from C:\Users\bion\AppData\Local\vcpkg\archives in 60.79 ms. Use --debug to see more details.
Installing zlib:x86-windows (1/1)...
Elapsed time for zlib:x86-windows: 20.03 ms

Total elapsed time: 2.662 s

The package zlib is compatible with built-in CMake targets:

    find_package(ZLIB REQUIRED)
    target_link_libraries(main PRIVATE ZLIB::ZLIB)

PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe remove zlib
The following packages will be removed:
    zlib:x86-windows
Removing zlib:x86-windows (1/1)...
PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe install zlib --no-binarycaching
Computing installation plan...
The following packages will be built and installed:
    zlib[core]:x86-windows -> 1.2.11#13
Detecting compiler hash for triplet x86-windows...
Installing zlib:x86-windows (1/1)...
Building zlib[core]:x86-windows...
-- Using cached zlib1211.tar.gz.
-- Cleaning sources at C:/Dev/vcpkg/buildtrees/zlib/src/1.2.11-e9a093319e.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Dev/vcpkg-downloads/zlib1211.tar.gz
-- Applying patch cmake_dont_build_more_than_needed.patch
-- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch
-- Applying patch add_debug_postfix_on_mingw.patch
-- Applying patch 0002-android-build-mingw.patch
-- Using source at C:/Dev/vcpkg/buildtrees/zlib/src/1.2.11-e9a093319e.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/vcpkg-cmake-wrapper.cmake
-- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/lib/pkgconfig/zlib.pc
-- Using cached msys-mingw-w64-i686-pkg-config-0.29.2-3-any.pkg.tar.zst.
-- Using cached msys-mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst.
-- Using msys root at C:/Dev/vcpkg-downloads/tools/msys2/9a1ec3f33446b195
-- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/debug/lib/pkgconfig/zlib.pc
-- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/copyright
-- Performing post-build validation
-- Performing post-build validation done
Elapsed time for zlib:x86-windows: 5.137 s

Total elapsed time: 7.36 s

The package zlib is compatible with built-in CMake targets:

    find_package(ZLIB REQUIRED)
    target_link_libraries(main PRIVATE ZLIB::ZLIB)

PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe remove zlib
The following packages will be removed:
    zlib:x86-windows
Removing zlib:x86-windows (1/1)...
PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe remove zlib
The following packages are not installed, so not removed:
    zlib:x86-windows
Removing zlib:x86-windows (1/1)...
PS C:\Dev\vcpkg>

BillyONeal · 2022-03-16T03:32:33Z

	<assembly name="abseil" run-date="2022-03-" run-time="1603:17:" time="25">
		<collection name="x86-windows" time="25">
			<test name="abseil:x64-windows" method="abseil[core]:x64-windows" time="12" result="Pass">
				<traits>
					<trait name="abi_tag" value="a61f543d8b9aede74d38c460244f4b829bcbb226b2fb3d5c421b8b76563c50c8" />
					<trait name="features" value="core" />
					<trait name="owner" value="x64-windows" />
				</traits>
			</test>
			<test name="abseil:x86-windows" method="abseil[core]:x86-windows" time="12" result="Pass">
				<traits>
					<trait name="abi_tag" value="c17d5a9436ead88d57eed554874ab2b714a5a89dee4c7e294ed4b5c5f870bcf6" />
					<trait name="features" value="core" />
					<trait name="owner" value="x86-windows" />
				</traits>
			</test>
		</collection>
	</assembly>

This change deletes the word "package" from several places where it is clear, and deduplicates "starting install" and "installing" messages. Before: ``` PS C:\Dev\vcpkg> .\vcpkg.exe install zlib Computing installation plan... The following packages will be built and installed: zlib[core]:x86-windows -> 1.2.11#13 Detecting compiler hash for triplet x86-windows... Restored 1 packages from C:\Users\bion\AppData\Local\vcpkg\archives in 43.57 ms. Use --debug to see more details. Starting package 1/1: zlib:x86-windows Installing package zlib[core]:x86-windows... Elapsed time for package zlib:x86-windows: 18.41 ms Total elapsed time: 2.266 s The package zlib is compatible with built-in CMake targets: find_package(ZLIB REQUIRED) target_link_libraries(main PRIVATE ZLIB::ZLIB) PS C:\Dev\vcpkg> .\vcpkg.exe remove zlib The following packages will be removed: zlib:x86-windows Removing package zlib:x86-windows... PS C:\Dev\vcpkg> .\vcpkg.exe install zlib --no-binarycaching Computing installation plan... The following packages will be built and installed: zlib[core]:x86-windows -> 1.2.11#13 Detecting compiler hash for triplet x86-windows... Starting package 1/1: zlib:x86-windows Building package zlib[core]:x86-windows... -- Using cached zlib1211.tar.gz. -- Extracting source C:/Dev/vcpkg-downloads/zlib1211.tar.gz -- Applying patch cmake_dont_build_more_than_needed.patch -- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch -- Applying patch add_debug_postfix_on_mingw.patch -- Applying patch 0002-android-build-mingw.patch -- Using source at C:/Dev/vcpkg/buildtrees/zlib/src/1.2.11-e9a093319e.clean -- Configuring x86-windows -- Building x86-windows-dbg -- Building x86-windows-rel -- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/vcpkg-cmake-wrapper.cmake -- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/lib/pkgconfig/zlib.pc -- Using cached msys-mingw-w64-i686-pkg-config-0.29.2-3-any.pkg.tar.zst. -- Using cached msys-mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst. -- Using msys root at C:/Dev/vcpkg-downloads/tools/msys2/9a1ec3f33446b195 -- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/debug/lib/pkgconfig/zlib.pc -- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/copyright -- Performing post-build validation -- Performing post-build validation done Installing package zlib[core]:x86-windows... Elapsed time for package zlib:x86-windows: 4.83 s Total elapsed time: 7.009 s The package zlib is compatible with built-in CMake targets: find_package(ZLIB REQUIRED) target_link_libraries(main PRIVATE ZLIB::ZLIB) PS C:\Dev\vcpkg> .\vcpkg.exe x-set-installed The following packages will be removed: zlib:x86-windows Starting package 1/1: zlib:x86-windows Removing package zlib:x86-windows... Elapsed time for package zlib:x86-windows: 9.93 ms Restored 0 packages from C:\Users\bion\AppData\Local\vcpkg\archives in 92.5 us. Use --debug to see more details. Total elapsed time: 14.01 ms PS C:\Dev\vcpkg> .\vcpkg.exe remove zlib The following packages are not installed, so not removed: zlib:x86-windows Package zlib:x86-windows is not installed PS C:\Dev\vcpkg> ``` After: ``` PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe install zlib Computing installation plan... The following packages will be built and installed: zlib[core]:x86-windows -> 1.2.11#13 Detecting compiler hash for triplet x86-windows... Restored 1 packages from C:\Users\bion\AppData\Local\vcpkg\archives in 60.79 ms. Use --debug to see more details. Installing zlib:x86-windows (1/1)... Elapsed time for zlib:x86-windows: 20.03 ms Total elapsed time: 2.662 s The package zlib is compatible with built-in CMake targets: find_package(ZLIB REQUIRED) target_link_libraries(main PRIVATE ZLIB::ZLIB) PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe remove zlib The following packages will be removed: zlib:x86-windows Removing zlib:x86-windows (1/1)... PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe install zlib --no-binarycaching Computing installation plan... The following packages will be built and installed: zlib[core]:x86-windows -> 1.2.11#13 Detecting compiler hash for triplet x86-windows... Installing zlib:x86-windows (1/1)... Building zlib[core]:x86-windows... -- Using cached zlib1211.tar.gz. -- Cleaning sources at C:/Dev/vcpkg/buildtrees/zlib/src/1.2.11-e9a093319e.clean. Use --editable to skip cleaning for the packages you specify. -- Extracting source C:/Dev/vcpkg-downloads/zlib1211.tar.gz -- Applying patch cmake_dont_build_more_than_needed.patch -- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch -- Applying patch add_debug_postfix_on_mingw.patch -- Applying patch 0002-android-build-mingw.patch -- Using source at C:/Dev/vcpkg/buildtrees/zlib/src/1.2.11-e9a093319e.clean -- Configuring x86-windows -- Building x86-windows-dbg -- Building x86-windows-rel -- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/vcpkg-cmake-wrapper.cmake -- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/lib/pkgconfig/zlib.pc -- Using cached msys-mingw-w64-i686-pkg-config-0.29.2-3-any.pkg.tar.zst. -- Using cached msys-mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst. -- Using msys root at C:/Dev/vcpkg-downloads/tools/msys2/9a1ec3f33446b195 -- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/debug/lib/pkgconfig/zlib.pc -- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/copyright -- Performing post-build validation -- Performing post-build validation done Elapsed time for zlib:x86-windows: 5.137 s Total elapsed time: 7.36 s The package zlib is compatible with built-in CMake targets: find_package(ZLIB REQUIRED) target_link_libraries(main PRIVATE ZLIB::ZLIB) PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe remove zlib The following packages will be removed: zlib:x86-windows Removing zlib:x86-windows (1/1)... PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe remove zlib The following packages are not installed, so not removed: zlib:x86-windows Removing zlib:x86-windows (1/1)... PS C:\Dev\vcpkg> ```

Needs tests.

src/vcpkg/install.cpp

# Conflicts: # src/vcpkg/build.cpp # src/vcpkg/install.cpp

BillyONeal · 2022-04-01T02:21:10Z

include/vcpkg/install.h

@@ -25,15 +27,19 @@ namespace vcpkg::Install

    struct SpecSummary


Long term, I think SpecSummary should be "freestanding" and not require the action plan that produced it to be held "alive" in order to be meaningful but that turned out to be more effort than I was willing to spend here. This at least goes somewhat in that direction.

ras0219-msft · 2022-04-01T20:38:42Z

Message diff, since there's much more unchanged text than changed text.

diff --git a/t1.txt b/t2.txt
index cb2874848..91f7d2012 100644
--- a/t1.txt
+++ b/t2.txt
@@ -4,9 +4,8 @@ The following packages will be built and installed:
     zlib[core]:x86-windows -> 1.2.11#13
 Detecting compiler hash for triplet x86-windows...
 Restored 1 packages from C:\Users\bion\AppData\Local\vcpkg\archives in x ms. Use --debug to see more details.
-Starting package 1/1: zlib:x86-windows
-Installing package zlib[core]:x86-windows...
-Elapsed time for package zlib:x86-windows: x ms
+Installing zlib:x86-windows (1/1)...
+Elapsed time for zlib:x86-windows: x ms
 
 Total elapsed time: x s
 
@@ -18,14 +17,14 @@ The package zlib is compatible with built-in CMake targets:
 PS C:\Dev\vcpkg> .\vcpkg.exe remove zlib
 The following packages will be removed:
     zlib:x86-windows
-Removing package zlib:x86-windows...
+Removing zlib:x86-windows (1/1)...
 PS C:\Dev\vcpkg> .\vcpkg.exe install zlib --no-binarycaching
 Computing installation plan...
 The following packages will be built and installed:
     zlib[core]:x86-windows -> 1.2.11#13
 Detecting compiler hash for triplet x86-windows...
-Starting package 1/1: zlib:x86-windows
-Building package zlib[core]:x86-windows...
+Installing zlib:x86-windows (1/1)...
+Building zlib[core]:x86-windows...
 -- Using cached zlib1211.tar.gz.
 -- Extracting source C:/Dev/vcpkg-downloads/zlib1211.tar.gz
 -- Applying patch cmake_dont_build_more_than_needed.patch
@@ -45,8 +44,7 @@ Building package zlib[core]:x86-windows...
 -- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/copyright
 -- Performing post-build validation
 -- Performing post-build validation done
-Installing package zlib[core]:x86-windows...
-Elapsed time for package zlib:x86-windows: x s
+Elapsed time for zlib:x86-windows: x s
 
 Total elapsed time: x s
 
@@ -55,18 +53,12 @@ The package zlib is compatible with built-in CMake targets:
     find_package(ZLIB REQUIRED)
     target_link_libraries(main PRIVATE ZLIB::ZLIB)
 
-PS C:\Dev\vcpkg> .\vcpkg.exe x-set-installed
+PS C:\Dev\vcpkg> .\vcpkg.exe remove zlib
 The following packages will be removed:
     zlib:x86-windows
-Starting package 1/1: zlib:x86-windows
-Removing package zlib:x86-windows...
-Elapsed time for package zlib:x86-windows: x ms
-Restored 0 packages from C:\Users\bion\AppData\Local\vcpkg\archives in x us. Use --debug to see more details.
-
-Total elapsed time: x ms
-
+Removing zlib:x86-windows (1/1)...
 PS C:\Dev\vcpkg> .\vcpkg.exe remove zlib
 The following packages are not installed, so not removed:
     zlib:x86-windows
-Package zlib:x86-windows is not installed
+Removing zlib:x86-windows (1/1)...
 PS C:\Dev\vcpkg>
\ No newline at end of file

strega-nil-ms

Please localize while you're touching these files; approved post that

src/vcpkg/remove.cpp

src/vcpkg/install.cpp

ras0219-msft

I converted the xUnit generator to use our XmlSerializer machinery.

I also pushed localization for all the touched messages.

BillyONeal · 2022-04-05T18:48:46Z

src/vcpkg/base/xmlserializer.cpp

@@ -90,6 +90,16 @@ namespace vcpkg
        }
        return *this;
    }
+    XmlSerializer& XmlSerializer::cdata(StringView sv)


@ras0219-msft I think this CDATA thing was a workaround for not having real XmlSerializer available at the time; should this go through data() instead now that you have proper escapes implemented?

The spec actually says "as a CDATA block": https://xunit.net/docs/format-xml-v2

(for the <message> child of a <failure> node)

The failure message as a CDATA block.

I don't think it should matter, but I didn't want to substantially change the current output.

BillyONeal · 2022-04-05T18:50:48Z

src/vcpkg/remove.cpp

        {
+            const RemovePlanAction& action = remove_plan[idx];
+            msg::println(msg::format(msgRemovingPackage, msg::spec = action.spec)
+                             .append_fmt_raw(" ({}/{})...", idx + 1, remove_plan.size()));


I see you added append_fmt_raw now; is this (x/y) notation common enough that we should add an explicit fn for it? (There are at least 2-3 such examples touched in this PR alone but I don't have a barometer on how many others there are)

These 2-3 are the only ones I've touched recently. I think that refactor can be done separately if/when it's deemed needed.

autoantwort · 2022-04-09T10:46:29Z

Hm I dislike that the x/y status is now displayed at another location for every package. This makes tracking the installation process harder.

BillyONeal · 2022-04-10T05:41:34Z

Hm I dislike that the x/y status is now displayed at another location for every package. This makes tracking the installation process harder.

I don’t feel strongly about where that is, only that the relatively useless “starting package” line is byebye

dg0yt · 2022-04-10T05:55:59Z

Having [x/y] first helps a lot when reading logs. For illustration, this is Ninja output:

[1/2] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1431~1.311\bin\Hostx64\x64\cl.exe   /TP -DUNICODE -D_UNICODE -ID:\installed\x64-windows-static\lib\mswu -ID:\installed\x64-windows-static\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1  -MTd /showIncludes /FoCMakeFiles\main.dir\popup.cpp.obj /FdCMakeFiles\main.dir\ /FS -c D:\installed\x64-windows-static\share\wxwidgets\example\popup.cpp
[2/2] cmd.exe /C "cd . && D:\downloads\tools\cmake-3.22.2-windows\cmake-3.22.2-windows-i386\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\main.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1431~1.311\bin\Hostx64\x64\link.exe  CMakeFiles\main.dir\popup.cpp.obj  /out:main.exe /implib:main.lib /pdb:main.pdb /version:0.0 /machine:x64 /nologo    /debug /INCREMENTAL /subsystem:console  D:\installed\x64-windows-static\debug\lib\wxmsw31ud_core.lib  D:\installed\x64-windows-static\debug\lib\wxbase31ud.lib  D:\installed\x64-windows-static\debug\lib\wxregexud.lib  winmm.lib  comctl32.lib  uuid.lib  oleacc.lib  uxtheme.lib  rpcrt4.lib  shlwapi.lib  version.lib  wsock32.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."

BillyONeal · 2022-04-11T17:52:03Z

Having [x/y] first helps a lot when reading logs.

Sure, that can make sense. Given that we didn't do that before this change though I'm not sure what's being seen as the regression?

BillyONeal mentioned this pull request Mar 16, 2022

[ci] Publish test results microsoft/vcpkg#23477

Closed

BillyONeal added 2 commits March 24, 2022 16:38

Built in implementation of microsoft/vcpkg#23477 .

20802b7

Needs tests.

BillyONeal force-pushed the ci-xunit branch from f0709b2 to 20802b7 Compare March 25, 2022 00:06

dg0yt reviewed Mar 25, 2022

View reviewed changes

src/vcpkg/install.cpp Outdated Show resolved Hide resolved

BillyONeal added 3 commits March 31, 2022 18:59

Merge remote-tracking branch 'origin/main' into ci-xunit

260137f

# Conflicts: # src/vcpkg/build.cpp # src/vcpkg/install.cpp

Fix POSIX build failures.

f3e4964

ref-ize SpecSummary as re quested by @dg0yt

9c4059d

BillyONeal marked this pull request as ready for review April 1, 2022 02:05

BillyONeal commented Apr 1, 2022

View reviewed changes

strega-nil-ms suggested changes Apr 1, 2022

View reviewed changes

src/vcpkg/remove.cpp Outdated Show resolved Hide resolved

src/vcpkg/install.cpp Outdated Show resolved Hide resolved

strega-nil-ms approved these changes Apr 1, 2022

View reviewed changes

ras0219-msft added 2 commits April 1, 2022 21:39

Use XmlSerializer to generate xUnit results

a0692c1

Localize touched messages

8893664

ras0219-msft approved these changes Apr 1, 2022

View reviewed changes

BillyONeal commented Apr 5, 2022

View reviewed changes

BillyONeal merged commit 8e8fb17 into microsoft:main Apr 6, 2022

BillyONeal deleted the ci-xunit branch April 6, 2022 01:15

autoantwort mentioned this pull request Apr 12, 2022

display progress counters at fixed locations #503

Merged

BillyONeal mentioned this pull request May 4, 2022

Update vcpkg-tool to 2022-05-05 microsoft/vcpkg#24526

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement published test results built in and reduce console chattiness. #437

Implement published test results built in and reduce console chattiness. #437

BillyONeal commented Mar 16, 2022 •

edited

Loading

BillyONeal commented Mar 16, 2022

BillyONeal Apr 1, 2022

ras0219-msft commented Apr 1, 2022

strega-nil-ms left a comment •

edited

Loading

ras0219-msft left a comment

BillyONeal Apr 5, 2022

ras0219-msft Apr 6, 2022 •

edited

Loading

BillyONeal Apr 6, 2022

BillyONeal Apr 5, 2022

ras0219-msft Apr 6, 2022

autoantwort commented Apr 9, 2022

BillyONeal commented Apr 10, 2022

dg0yt commented Apr 10, 2022

BillyONeal commented Apr 11, 2022

		@@ -25,15 +27,19 @@ namespace vcpkg::Install

		struct SpecSummary

Implement published test results built in and reduce console chattiness. #437

Implement published test results built in and reduce console chattiness. #437

Conversation

BillyONeal commented Mar 16, 2022 • edited Loading

BillyONeal commented Mar 16, 2022

BillyONeal Apr 1, 2022

Choose a reason for hiding this comment

ras0219-msft commented Apr 1, 2022

strega-nil-ms left a comment • edited Loading

Choose a reason for hiding this comment

ras0219-msft left a comment

Choose a reason for hiding this comment

BillyONeal Apr 5, 2022

Choose a reason for hiding this comment

ras0219-msft Apr 6, 2022 • edited Loading

Choose a reason for hiding this comment

BillyONeal Apr 6, 2022

Choose a reason for hiding this comment

BillyONeal Apr 5, 2022

Choose a reason for hiding this comment

ras0219-msft Apr 6, 2022

Choose a reason for hiding this comment

autoantwort commented Apr 9, 2022

BillyONeal commented Apr 10, 2022

dg0yt commented Apr 10, 2022

BillyONeal commented Apr 11, 2022

BillyONeal commented Mar 16, 2022 •

edited

Loading

strega-nil-ms left a comment •

edited

Loading

ras0219-msft Apr 6, 2022 •

edited

Loading