Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[git registry] Add "reference" key #155

Merged
merged 36 commits into from
Nov 5, 2021
Merged

[git registry] Add "reference" key #155

merged 36 commits into from
Nov 5, 2021

Conversation

srgbtl
Copy link
Contributor

@srgbtl srgbtl commented Aug 12, 2021 •
edited
Loading

Fixes: microsoft/vcpkg#19495
Relates to: #99

Sergii Baitala and others added 3 commits August 12, 2021 14:53
@srgbtl srgbtl changed the title Fetch from baseline [git registry] Fetch from baseline Aug 12, 2021
@srgbtl srgbtl marked this pull request as ready for review August 12, 2021 13:40
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

strega-nil-ms
strega-nil-ms suggested changes Oct 1, 2021
View reviewed changes
@strega-nil-ms strega-nil-ms changed the title [git registry] Fetch from baseline [git registry] Add "reference" key Oct 1, 2021
@ras0219-msft ras0219-msft self-requested a review October 1, 2021 22:26
strega-nil-ms
strega-nil-ms approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs review from @ras0219-msft

ras0219-msft
ras0219-msft requested changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s are a supported character in git remote urls (for example: ssh://[email protected]:user/repo_name.git)

@srgbtl
Copy link
Contributor Author

srgbtl commented Oct 7, 2021

@ras0219-msft @strega-nil-ms Functionality is reimplemented based on your suggestions. Also, one more e2e test was added. PR is ready for review.

@srgbtl srgbtl requested a review from ras0219-msft October 11, 2021 08:37
@srgbtl srgbtl requested a review from ras0219-msft October 29, 2021 18:53
ras0219-msft
ras0219-msft reviewed Nov 4, 2021
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM other than my one comment. Thanks for the great work!

@BillyONeal BillyONeal merged commit c8d5f47 into microsoft:main Nov 5, 2021
@BillyONeal
Copy link
Member

Thanks for the new key!

@srgbtl srgbtl deleted the support-branch-baseline branch November 5, 2021 06:09
@ras0219-msft ras0219-msft mentioned this pull request Nov 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom git registry to work with branches
5 participants
@srgbtl @BillyONeal @ras0219-msft @strega-nil-ms @strega-nil