Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom git registry to work with branches #19495

Closed
srgbtl opened this issue Aug 11, 2021 · 3 comments · Fixed by microsoft/vcpkg-tool#155
Closed

Custom git registry to work with branches #19495

srgbtl opened this issue Aug 11, 2021 · 3 comments · Fixed by microsoft/vcpkg-tool#155
Assignees
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:registries This PR or Issue pertains to the registries feature

Comments

@srgbtl
Copy link
Contributor

srgbtl commented Aug 11, 2021


Is your feature request related to a problem? Please describe.
As a developer, I want to be sure that a new port in the custom git registry is consumable before merging to main.

  1. New branch is created in custom registry repo and the new port is added
  2. In repo that uses this registry I am changing baseline to point a commit in branch and build the project
  3. If the project is successfully built I am sure I can merge my changes to the main branch.

Proposed solution
Add a new field to Registry object to specify a branch to use. If the field is not specified HEAD is used.

Describe alternatives you've considered
N/A

Additional context
N/A

@srgbtl
Copy link
Contributor Author

srgbtl commented Aug 12, 2021

Just found #17726 and microsoft/vcpkg-tool#99
@strega-nil-ms is there any progress on this PR? I might help with this PR. I have an environment ready to test this.
CC: @BillyONeal @ras0219-msft

@PhoebeHui PhoebeHui added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Aug 13, 2021
@strega-nil-ms
Copy link
Contributor

@srgbtl unfortunately, I've been busy with other stuff right now, so I've not been able to work on it; if you'd be up for it, it'd be great if you could take up the torch.

@PhoebeHui PhoebeHui added the info:registries This PR or Issue pertains to the registries feature label Aug 18, 2021
@srgbtl
Copy link
Contributor Author

srgbtl commented Aug 20, 2021

@BillyONeal @ras0219-msft Looking forward to hear any feedback and/or vision on this issue. We really need this feature, and I'm wondering whether to switch to fork to use it.

@microsoft microsoft locked and limited conversation to collaborators Aug 23, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:registries This PR or Issue pertains to the registries feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants