Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolve allowed resolved even if @path is used explicitly #5016

Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Nov 7, 2024

fix #4967

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 7, 2024

All changed packages have been documented.

  • @typespec/http
Show changes

@typespec/http - fix ✏️

Uri template attributes were not extracted when parameter was explicitly mark with @path or @query as well

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin added this pull request to the merge queue Nov 7, 2024
Merged via the queue into microsoft:main with commit 34af566 Nov 7, 2024
23 checks passed
@timotheeguerin timotheeguerin deleted the fix/path-explicit-allow-reserved branch November 7, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AllowReserved is false if we add @path in path param for uri template managed route
3 participants