Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: AllowReserved is false if we add @path in path param for uri template managed route #4967

Closed
4 tasks done
MaryGao opened this issue Nov 5, 2024 · 0 comments · Fixed by #5016
Closed
4 tasks done
Assignees
Labels
bug Something isn't working lib:http triaged:core

Comments

@MaryGao
Copy link
Member

MaryGao commented Nov 5, 2024

Describe the bug

We met this issue in KeyVault spec and we try to enable the allowReserved as true.

Say we have below two cases and only the first one has AllowReserved as true but the second one would be not, is this by design or a bug?

playground

import "@typespec/http";
using TypeSpec.Http;

// case 1: with "x-ms-skip-url-encoding": true
@route("/{+scope}/foo1")
op foo1(scope: string): void;

// case 2: wihtout "x-ms-skip-url-encoding": true
@route("/{+scope}/foo2")
op foo2(@path scope: string): void;

/cc @maorleger

Reproduction

NA

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib:http triaged:core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants