-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin: add support for [XYZ]MODEM file transfers #1999
Comments
This comment has been minimized.
This comment has been minimized.
@zadjii-msft |
1 similar comment
@zadjii-msft |
@zadjii-msft windows terminal should support sz/rz protocol and popout dialog box, I can't reopen this issue, please reopen it, it is very useful feature. |
@zadjii-msft I think |
So I still don't know why the terminal would need to add support for Maybe I don't understand how |
@zadjii-msft If I want to send a file from server to laptop, Other Terminal do this, so I think Windows Terminal should do it too. |
@zadjii-msft Terminal should support |
So do you think user should be responsibility to display that picker? |
I'm reopening this one and putting it on the infinite backlog. @qin-nz: We're not going to do this ourselves, but it is a valuable feature and it would be good to think about it when plugin support is written (#555) @zadjii-msft: This is a weird/interesting thing. lszrz is a package that implements the [XYZ]MODEM set of protocols, and is typically used for transferring files over serial connections to remote machines. The deal, though, is that that data must either be multiplexed-with or totally replace the tty stream. It's the terminal emulator's job to stop sending user input and waiting for connection output and instead send encoded file data packets and wait for ACKs (or the other way around.) lszrz only includes the client portions that "send a file to the terminal" or "receive a file from the terminal," and the terminal needs to be complicit. |
sz rz
command!
Oh my god, that's insane. Well yea of course I didn't understand that, that's a totally different style of application than anything I've ever heard of before. I'd think there would be a better way of doing this, such that the Terminal application didn't have to be directly involved in this process (maybe using a pty or something) but hey if that's how it works, that's how it works. Sounds like a perfect extension scenario. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I developed a ssh command line tool to support sz/rz for Windows Terminal in WSL. When rz/sz command is found, it will call OpenFileDialog/FolderBrowserDialog through a powershell script, and then pass the file path to rz/sz to finish upload or download. I hope it helps somehow. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Hello, I made a ssh wrapper to support rz and sz. I hope you find it useful. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
If u need. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Security Fortress servers don't seem to work very well when they exist |
Yeah, the feature is too useful to transfer my file! Hope to see it soon in WT! |
This comment was marked as spam.
This comment was marked as spam.
The reason that the request for zmodem support comes for the Terminal application, is because the Zmodem protocol is designed to use a very characteristic character sequence for handshaking between the two ends, which is designed to be easy to recognize for the terminal emulator and start the zmodem client locally on the character stream handled by the terminal app. It is very useful for situations where you cannot create a direct TCP/IP connection from/to a given network host but you have a serial/telnet connection to the host. |
This problem has not been resolved for so long, I think it is not a technical problem, but a management problem, who can come forward to coordinate and resolve this matter? |
Whether it's "management" or "technical" isn't really up for debate. This feature request is the perfect combination of (1) not important enough to prioritize ahead of other work and (2) already handled better by other software. WT isn't yet intended to be the best--say--serial terminal. It works for that, sure, but it's missing some important things that would make it the best... such as x/y/zmodem support. But it's also missing more basic things like actually opening a serial port as an endpoint. This is a popular community request, but it is by no means the most popular one. Once we're through with the more important foundational ones, we'll be better equipped to tackle this one. For now, I'm going to lock the thread. It's been open for a while and the new replies haven't really cleared up the specific requirements for data exchange protocols here, so it'll serve the community better as an upvote aggregator rather than an open-ended discussion about how we just don't have it yet. 😄 (Edited after the fact to add!) |
For anyone stuck on using It is recommended to use # Install trzsz-ssh ( tssh ) in Windows Terminal
scoop install tssh / winget install tssh / choco install tssh
# Log in to the remote server using tssh. It works similar to ssh.
tssh remote_server
# Install trzsz-go on the remote server. Please check https://trzsz.github.io/go
yay -S trzsz / sudo apt install trzsz / sudo yum install trzsz / etc...
# Upload files like rz
trz
# Upload directories
trz -r
# Download files like sz
tsz file
tsz /path/to/file
# Download directories
tsz -r dir
tsz -r /path/to/dir
# Install trzsz-ssh ( tssh ) in Windows Terminal
scoop install tssh / winget install tssh / choco install tssh
# Install lrzsz ( rz / sz ) on local Windows, or download from https://github.com/trzsz/lrzsz-win32/releases and add it to PATH
scoop install lrzsz / choco install lrzsz
# `tssh -V` should show "trzsz ssh 0.1.15"
tssh -V
# Add the following configuration to C:\Users\xxx\.ssh\config
Host *
#!! EnableZmodem Yes
# Log in to the remote server using tssh. It works similar to ssh.
tssh remote_server
# Now you can use rz / sz
rz
sz xxx |
refer to the title
The text was updated successfully, but these errors were encountered: