-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Region invalidation malfunctioning after text buffer has begun to scroll #11214
Comments
I've also been seeing this since moving to 1.11 preview (usually with various |
I've been playing with this all morning and can't seem to get a repro. Frankly I haven't seen this once on the 1.11+ selfhost, and I'm not sure anyone else on the team has either. Not sure how we're going to be able to dig in more here without a at least semi-consistent repro. I'm gonna move this out of 1.12 into 2.0 for now. If it's more widespread, then maybe that'll help us ID a repro. If it's not, then at least that's a good sign. |
My win11 recently updated to 22000.194 (the final release) and I haven't seen it since -- I wonder if it was something more fundamental in the kernel? |
Some more notes:
Could it be DPI related? scaling is 100% on the external screen. My sb3 is at 200% and native resolution. |
Version 1.12.2931.0 remains broken on Win10 for me. |
I've been seeing this on my second display in the last few days. I'm running on a Surface Book (1st gen) and the terminal fails to render lines only if it's on the external monitor (1080p via DP) which is set to 100% scale. The built-in is set to 175% scale 3000x2000 native resolution and is working fine. It loses a LOT of lines during fast scrolling, often more than 50% of them. The behavior described of highlighting them to get them to reappear works the same as other reports. I have version 1.11.2921.0 from the Windows Store, which last updated Oct 29th. |
1.12.2931.0 still broken |
Recently got a 4k monitor (150% scaling), and ran into this issue as well on my secondary monitor (FullHD, no scaling). Version: 1.12.10393.0 |
This was also reported in MSFT:38160934. Alas, for the time being, we still don't have any beat on what triggers this. I don't recall any rendering changes that would have regressed around 1.11, though.... maybe this is fallout from #9820. That's where I'd look first. |
I could reproduce this consistently by:
|
I'm really hoping this was fixed as a side-effect of #12713 (but that hasn't yet been pushed out in a servicing build yet). |
From my perspective on how it manifests, that looks hopeful for sure. |
Hey @oising you still seeing this, like maybe on 1.18/? We've re-written the renderer a couple times since this was filed, I'm thinking this might have gone away on its own 😅 |
@zadjii-msft Hey Mike! Nope, haven't seen this in a long time. I've got redraw off, s/w off and using the new renderer. I guess close it? |
Closed as fixed. |
Windows Terminal version (or Windows build number)
1.11.2421.0
Other Software
Steps to reproduce
Parts (or the entirety) of the buffer should be invisible, yet will be rendered visible if selected with the mouse
e.g.
![image](https://user-images.githubusercontent.com/1844001/133122825-d8f2f2c0-898d-45f3-9fd3-101933a4f004.png)
after selection:
![image](https://user-images.githubusercontent.com/1844001/133122881-af658e9b-2bd3-42fa-bad5-03dd24e6f2d9.png)
Expected Behavior
Actual Behavior
The text was updated successfully, but these errors were encountered: