-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Previous command disappears from the terminal output when it fills the current terminal height #12805
Comments
What do you have in your PowerShell profile? |
@zadjii-msft path returned by |
This is crazy, and I can't seem to repro this at all, despite the repro steps being pretty straightforward. If this were a conpty issue, then maybe we fixed it between 1.11 and 1.15? But nothing immediately comes to mind... |
I can still reproduce it in Terminal 1.14.1962.0 (and different versions of VS Code) and Windows 10.0.19044.0 on several machines. Make sure that the output of the command is exactly long enough for the executed command to be at the topmost line after it's done. |
Maybe it's a timing thing then? Cause I couldn't get this to repro even on a 1.10 build of the Terminal. Maybe it really needs all the output to come in a single conpty frame, and my hardware is just too fast for that. |
Are you testing on Win10? Is HW acceleration enabled (I haven't verified that it is or not in my case, but I assume it's the same across the board since I haven't changed any defaults)? There is no timing at play, as far as I can tell. I can wait 10-15 seconds between running commands and the result is the same. The reproducibility rate is 100%. I've also run it on 3 reasonably powerful machines (2-core HT ultrabook, 6-core HT laptop and 4-core Desktop). Is there anything else I can provide to help move this issue? |
Hey we think this might be a known issue in older versions of PsReadline: PowerShell/PSReadLine#724 Does this repro if you I can't believe I didn't catch that before! |
@zadjii-msft hi. PSReadline seems to be impossible to remove from my machine (or to cleanly update due to name change for that matter) and I don't know if I can safely delete its folder in |
Well that sure is wacky! Alas, I'm not the powershell expert so I can't help with that, but hey, glad it went away? |
Windows Terminal version
1.11.3471.0
Windows build number
10.0.19043.0
Other Software
No response
Steps to reproduce
I've first discovered this issue in VS Code and described it (with the gifs and steps to reproduce) here: microsoft/vscode#146450
I was able to reproduce it in the latest Windows Terminal.
Expected Behavior
When scrolling back the command output is delimited by the commands themselves.
![image](https://user-images.githubusercontent.com/2046350/161256507-bbdb2b6d-b099-405c-ba6d-6491f6447f06.png)
Actual Behavior
The problematic command disappears from the output, "merging" the two commands stdout together (in the images below the output after the empty line was generated by
![image](https://user-images.githubusercontent.com/2046350/161256642-baacfbf5-8c7a-4fa7-ad34-7538a3d4cd63.png)
![image](https://user-images.githubusercontent.com/2046350/161255838-bbb56806-764c-43e6-a4ba-09bfa1dfb734.png)
python -c "print('foo\n' * 27)"
).The text was updated successfully, but these errors were encountered: