Use default brush for borders #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
NickGerleman
approved these changes
Jun 15, 2020
NickGerleman
added
the
Breaking Change
|
Marking as breaking since this is a behavior change we may want to document. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4682
On other platforms, borders draw a solid color (black) by default if no brush color is specified. On Windows, we are drawing transparent.
This change fixes the mismatch by using a default brush when no brush color is specified. The default brush will be a theme brush that draws black on light theme, and white on dark theme.
A couple optimizations:
1 - the brush is cached in a per-UI-thread singleton class, as looking up the theme resource isn't free
2 - the default brush is only set if the border has thickness, to avoid the cost of setting a brush in the case where nothing draws
Microsoft Reviewers: Open in CodeFlow