Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borderColor draws black by default on all other platforms, but draws transparent on Windows #4682

Closed
kmelmon opened this issue Apr 22, 2020 · 3 comments · Fixed by #5213
Closed

Comments

@kmelmon
Copy link
Contributor

kmelmon commented Apr 22, 2020

I noticed this while debugging RTL issues...

See this snack:
https://snack.expo.io/PJTPipoRS

Notice the outer border, which has border thickness but no borderColor pop set, draws a black border. It draws black on all platforms supported by Snack.

On react-native-windows, the border draws transparent (but does take up layout space). This inconsistency is bound to cause problems for xplat code.

I'm not sure if we should default to black, or a brush that's guaranteed to contrast against the default theme. Needs a bit of investigation.

@kmelmon kmelmon added the bug label Apr 22, 2020
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 22, 2020
@kmelmon kmelmon changed the title borderColor draws black by default on all other platforms borderColor draws black by default on all other platforms, but draws transparent on Windows Apr 22, 2020
@chrisglein chrisglein added Area: Borders and Brushes and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Apr 27, 2020
@chrisglein
Copy link
Member

Need to have the right default here that matches the other platforms (and perhaps cares about light/dark theme).

@kmelmon
Copy link
Contributor Author

kmelmon commented Jun 4, 2020

This looks like a super easy fix, and is needed before fixing #4678. I'll take this.

@kmelmon kmelmon self-assigned this Jun 4, 2020
@kmelmon kmelmon modified the milestones: Backlog, 0.63 (M6) Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants